15:03:52 #startmeeting IRC Development Meeting 5 February, part 1 15:03:52 Meeting started Thu Feb 5 15:03:52 2015 UTC. The chair is cait. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:03:52 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:03:52 The meeting name has been set to 'irc_development_meeting_5_february__part_1' 15:03:54 Coffee: |=============>|.....| 75 % 15:03:55 welcome 15:03:55 Welcome to zombo.com 15:04:00 #introductions 15:04:05 please introduce yourself with #info 15:04:11 #info Tomas Cohen Arazi, Universidad Nacional de Cordoba 15:04:17 #info 15:04:24 woops 15:04:25 #info Barton Chittenden, Bywater Solutions, Louisville KY, USA 15:04:27 #info Benjamin Rokseth, Oslo Public Library 15:04:28 #info the agenda for today's meeting can be found at http://wiki.koha-community.org/wiki/Development_IRC_meeting_5_February_2015 15:04:29 s 15:04:34 #info Brendan Gallagher ByWater Solutions 15:04:38 #info Katrin Fischer, BSZ 15:04:41 #info Owen Leonard, Athens County Public Libraries, Ohio 15:04:44 #info Nate Curulla ByWater Solutions 15:04:47 #info Ed Veal, ByWater Solutions 15:04:58 #info Jared Camins-Esakov, C & P Bibliography Services 15:04:59 #info Coffee: |=============>|.....| 75 % 15:05:16 couldn't resist. 15:05:33 #topic RM 3.18 comments 15:05:48 * cait hands the keyboard to tcohen 15:05:49 3.20? 15:05:58 you are right, but the agenda was not updated :) 15:06:08 #topic RM 3.20 comments 15:06:17 it is 15:06:32 now :) 15:06:33 magnuse: HI 15:06:57 oh 15:07:10 the agenda is missing the "deprecate Squeeze support" line 15:07:21 ok, I'm worried about several stuff that is stuck 15:07:31 most of it is on the next topic list 15:07:46 we need to make a decision on how/what to catch 15:08:17 it is a trade-off between the minimum possible db access vs reasonable invalidation 15:08:33 will discuss that later 15:08:49 and there's also the recent problems with zebra's performance on the list 15:08:52 #info Hi Zeno Tajoli, Cineca (Italy) 15:09:37 we are in talks with indexdata on some problems we found (dcook and I) 15:09:44 they promised a response 15:10:10 but it seems that some important koha bits are not having enough attention 15:10:26 - plack support (what's missing needs devs to take a look) 15:11:02 - searching (neither QP completeness or search performance have people worried/working on that) 15:11:19 bag: HI 15:11:19 bidet, magnuse 15:11:29 I started some tests on optimizing/refactoring C4::Search::searchResults 15:11:47 * magnuse wanders off 15:11:52 we testing on bugs about QueryParsing ? 15:11:57 but that's WIP, and we have stuff already on the pipe, i.e. bugs 15:12:09 #info Kyle M Hall, ByWater Solutions 15:12:13 welcome tajoli, nice to hear that 15:12:35 this is just general comments on what is worring me now 15:12:49 ok, that's it for now 15:13:10 GRS1 and non-XSLT view removal would ease the refactoring 15:13:19 so, lets move forward, ciat 15:13:20 cait 15:13:36 ok 15:13:37 #info Jonathan Druart, BibLibre 15:13:46 any comments tho? 15:14:10 #topic REST API RFC 15:14:21 ashimema: all yours 15:14:32 #link http://wiki.koha-community.org/wiki/New_REST_API_RFC 15:14:51 ahh.. 15:14:51 REST all the things! 15:14:55 didn't realise thre was a meeting 15:15:00 #info Joy Nelson ByWater Solutions 15:15:14 #info Martin Renvoize, PTFS Europe 15:15:29 yeah.. beyond what we've said so far on that page this isn't much.. 15:15:39 we're hoping to have a gathering to discus it as hackfest.. 15:15:51 I fail to see why we should move svc to svc_legacy, which will break existing services when we can just start fresh with /rest/v1/ 15:15:56 I was hoping to find a time that means people across the world can join in a bit. 15:16:05 khall: I agree 15:16:16 I'm fine with that.. 15:16:17 agree, versioning APIs are crucial 15:16:22 'twas Joubu's thought to shift it.. 15:16:43 ashimema: I guess he wanted to keep /svc 15:16:53 besides the name.... 15:17:16 Joubu: what's your experience with koha-resful regarding how you manage the routing? 15:17:31 I think the main thing is that we should be ancourages work in the new namespace.. and discourages work in the old as soon as we decide to go for it.. 15:17:32 I don't have any experience with koha-restful 15:17:39 I didn't dev it 15:18:04 koha-restful dev will be present at the Marseille hackfest, will be good to talk with them 15:18:04 #info Jeff Godin, Traverse Area District Library (TADL) 15:18:09 we have been using koha-restful some at OPL, though we are wondering about if its maintained 15:18:14 definitely. 15:18:28 what i'v seen about koha-restful 15:18:30 bensinober: we used it, yes 15:18:37 we use it! 15:18:42 serendipitously stumbling into this meeting and finding it interesting/potentially-relevant. :-) 15:18:47 is that it is well organized, and has a single front-end script 15:18:48 I think the real first stage in this is to get some good clear guidlines for it bashed out.. 15:18:55 that handles the routing for each endpoint 15:18:55 maybe not tested with koha 3.18 15:19:01 there are some issues on 3.16 and 3.18 both 15:19:09 then no-one's in the dark with how things 'should' be done.. and the QA team have somthing to refer to when feeding back 15:19:20 I think that's the way to go 15:19:44 agreed. 15:20:01 either using something like dancer, or mimicking koha-restful using CGI::Application::Dispatch or an equivalent solution 15:20:04 koha-restful is compeletly self contained and doesn't really lend itself to inclusion in koha as is.. 15:20:19 I really like Jesse Weaver's work 15:20:42 having said that.. in some ways being self contained is nice 15:20:47 as a sidenote, /svc is already used internally for patron lookup, preference settings etc. 15:21:11 but there is sparse documentation 15:21:20 Jesse's work is certainly rather nice.. though it's basically just a clone of a small aprt of what allot of other frameworks give you out of the box. i.e dancer, mojo etc 15:21:45 ashimema: what would be your preference? building on jesse's or swtiching it to a framework? 15:21:57 in the medium term I'd like to replace all the current internal use of svc with new rest stuff 15:21:58 just a little worried about having a framework discussion :) 15:22:00 ashimema: right. I'm 100% for the rest api being baked in to Koha 15:22:11 I'm all for including Jesse's stuff.. 15:22:14 and i'd like to see something inside koha as kyle says 15:22:36 Joubu: do you have a preference? 15:22:40 seems to me a good idea to join the work of Jesse w and build out a internal API that could have selected services exposed 15:22:41 if we chose to use a framework it should be all or nothing... or we're just building ourselves into two corners again. 15:22:51 not really 15:23:10 jesse's stuff is nice.. as it take's some of the best bits of the frameworks and effectively backports them to our 'koha' framework. 15:23:51 the question is 15:24:04 ashimema: is it something we could shift to a framework later and have this as a first step? 15:24:05 does #bywater have a schedule for it? 15:24:18 I 'think' with Jesse's work, if we later wanted to port it to Dancer/mojo it wouldn't be an aweful job. 15:24:40 Jesse's given me the all clear to submit his work thus far tcohen ;) 15:24:47 yay :) 15:25:02 is there any sample implementation to look at? 15:25:05 What I was going to do was split down his tree into a whole set of bugs.. 1 with the core module in.. then a bug for each svc we port.. 15:25:12 he was trying to do it all at once.. hense the hold up. 15:25:22 * cait dislikes all at once things 15:25:39 ashimema: core + one sample endpoint implemented would be a good start 15:25:45 ashimema: sounds like an excellent plan 15:25:46 https://github.com/pianohacker/koha/commit/40908d6e58c40e6ffaa488266a70ef5233fe9642 15:25:58 it could help eythian on his effort with patron management 15:26:03 #link https://github.com/pianohacker/koha/commit/40908d6e58c40e6ffaa488266a70ef5233fe9642 15:26:13 I'll be submitting cash management at some point.. and that relies heavily upon it.. showing good practice for three routes at least.. 15:26:17 great idea 15:26:19 I'd say bugs for Core -> New SysPref Servce -> Replace Old SysPref Service with New 15:26:24 and i've also got some other examples I'll be posting along with it.. 15:26:40 khall.. defoo.. that's the best plan I reckon 15:27:39 tcohen et al. were we ok with putting eythians patron api stuff in as is.. with the undertsnading that it'll be deprecated fairly quickly once we have had the restful debate at hackfest.. 15:27:54 I'd be more than happy to help write up some Koha REST api standards 15:27:57 I'm happy doing the work to port it.. seeing as I've already got a half baked one here to play with ;) 15:28:09 khall.. seen the wiki page above? 15:28:19 would certainly apreciate your input on it too.. 15:28:20 can i add actions? :) 15:28:31 eat your heart out cait ;) 15:28:32 ashimema: i don't have any problem with pushing eythian's work on /svc 15:28:36 #action ashimema to submit patches for the new restful API - core + a sample 15:28:53 * ashimema to fit this all around having baby ;) 15:28:56 got to go, if there are anything to vote on, I'm good with ashimemas plan 15:29:01 ashimema: yes, I think it's a very good base. Honestly, the more terse we can make it the better it will be followed 15:29:03 maybe should we wait for the discussion at the hackfest before writing anything? 15:29:14 see you in Marseille! 15:29:16 please don't tie the new restful api to a new sysprefs service implementation 15:29:22 someone else i need to action? :) 15:29:27 trying to catch up reading 15:30:16 #action khall volunteers helping out with the RFC and writing up some guidelines 15:30:41 tcohen: that was just an example, we can find something else as a starter 15:30:52 khall: all good 15:31:03 maybe search ? :-D 15:31:12 maybe soemthing easy and existing? :) 15:31:17 adding a record? ) 15:31:20 not sure 15:31:21 ok 15:31:22 moving on? 15:31:22 tcohen: what we really need is to get datatables to play well with a standard api instead of the special stuff it prefers 15:31:36 angular 15:31:38 angular 15:31:41 lol 15:31:54 we are all on the same track, moving on :-D 15:32:03 #topic Zebra / Facet issues 15:32:05 Marseille will be really fun 15:32:16 hopefully productive fun - but fun i am sure :) 15:32:29 hackfest++ 15:32:43 I'd like to add an obvervation here about zebra facets 15:32:45 i've collected several stuff about the "zebra facets" feature i'd like to share 15:32:56 tcohen goes first :) 15:33:30 - they are problematic with the latest Zebra (2.0.59) already present in Testing 15:34:20 2) their performance is not logaritmic on the amount of records you ask them ti be calculated on 15:34:58 about (1) i'm in talks with indexdata, and will try to have something about it soon, so it doesn't catch us 15:35:34 about (2) the preference facetNumRecs (present in zebra-biblios-dom.xml) is set to 1000 by default 15:36:03 it was a good default, but it seems that large databases (more than 1M records) see some impact on speed. 15:36:25 at UNC we see a gain in speed instead, but our databases are small (90K the bigger) 15:36:38 I have opened a bug report to explain what I have tried 2 days ago (bug 13665) 15:36:38 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 major, P5 - low, ---, gmcharlt, NEW , Retrieve facets from zebra is slow 15:36:55 tested on a 1M record DB 15:37:34 i'm experimenting with retrieving all facets at once, whch seems optimal, but need indexdata's feedback on two problems 15:38:26 a) there seems to be a bug that prevents retrieving more than 8 facets at once (they filled a bug ZEB-663 as per my request) 15:39:01 b) there's no current way to change the current behaviour of facet retrieval failing if some facet is not previously populated 15:39:10 i'm working on both 15:39:14 at once, heh 15:39:43 it'd be great to have a sample DB with more than 1M records *with items* 15:39:48 tcohen++ 15:39:49 to play with 15:39:55 I don't have it 15:40:08 i have done some testing with facets and ran into somethings that confused me a little 15:40:15 1) the facets changed with the sorting i chose 15:40:48 2) for a result set of 22 records it didn't list all itemtypes as facets that were present in the result set in some 'sort' cases 15:41:07 if the default is set to 1000... i don#t se why this could happen yet 15:41:22 it didn't onyl happen for itemtypes but also for other categoreis, just quite obvious there 15:41:35 would be interested if there is an explanation yet or if people experience similar things in testing 15:41:38 1: what was the number of result? > 1000? 15:41:44 22 15:42:15 weird 15:42:19 yep 15:42:42 I'm finding datatables really slow 15:42:51 Are the facets sorted by "count" ? 15:43:08 I couldn't reproduce cait's problem FTR 15:43:44 (talking about (2)) 15:44:22 i know - maybe we can just keep it in mind and an eye on it? 15:44:25 ok movingon? 15:44:30 there is also an other problem on Zebra: 'Zebra hyphen truncating search' on koha-devel 15:44:31 anything to #info 15:44:41 cait: did u get access to the z39.50 port? 15:44:46 not yet 15:44:50 too busy today :( 15:44:53 will see about it 15:44:56 to try the facet retrieval directly from zebra 15:45:01 ready to move on? 15:45:06 and spot possible Koha problem? 15:45:51 i will try to arrange better testing or find samples in my dev database 15:45:56 #topic Non-XSLT removal 15:45:57 #action people that have issues with zebra facets, contact tcohen who will be looking at those 15:46:03 :) 15:46:21 Non-XSLT removal 15:46:57 it is already deprecated, since July 2014 15:47:17 #link http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 15:47:17 04Bug 12561: normal, P5 - low, ---, oleonard, NEW , Omnibus: Deprecate non-XSLT detail and result views 15:47:19 does someone have the actions about this on hand? 15:47:40 i think i found another - the opac summary field in the itemtype configuration - that's non-xslt only? if used at all still? 15:48:13 the problem with killing it is that we will have a feature loss for some libraries 15:48:23 bug 13327 for example 15:48:23 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 normal, P5 - low, ---, oleonard, NEW , OPACPopupAuthorsSearch doesn't work with XSLT views 15:48:46 or bug 11426 15:48:46 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426 normal, P5 - low, ---, oleonard, NEW , Make HighlightOwnItemsOnOPAC work with XSLT 15:48:51 khall: woudl you be able to port that to xslt? 15:48:55 are they aware of its deprecation? concerned? 15:49:28 cait: I think it'll have to be ported 15:50:01 I'm no xslt wizard though, so I don't know what it will involve 15:50:44 khall: is it just template stuff? 15:51:10 tcohen: my guess is the hard part is getting the data to the xsl template 15:51:29 specifically? 15:51:58 users-branch? 15:52:11 I can't give any specifics at the moment, I'll need to reappraise myself of the feature 15:53:13 i think we maybe need a more comprehensive list - maybe lookint at the prefs on the normal views? 15:53:24 it's deprecated, but need to decide about features 15:53:28 it's all bloody mixed 15:53:31 or maybe say they will get removed 15:54:05 can we set a deadline for next meeting to feed the bug with depending things? 15:54:12 woudl someone volunteer to look at the code? 15:54:40 looks like i did volunteer last time ... oops 15:54:43 So we know some things need to get ported, but does that block agreement on the plan to remove the normal view? 15:54:44 i have no objections 15:55:07 it's something we didn't do so far 15:55:10 breaking features :) 15:55:12 but we could 15:55:20 I also have no objections. Growing pains are inevitable. But the advantage of only one view to update is worth it 15:55:22 the question is if they will be ported before or after removal 15:55:29 Not on purpose anyway cait 15:55:34 true 15:55:38 cait: before would also be preferred, but not required 15:55:51 #action cait volunteers again to look into creating a better list of features missing from XSLT view 15:56:04 so can we have a vote 15:56:09 ? 15:56:12 yes 15:56:30 please vote on removal - keeping in mind that features might not be ported on time 15:56:41 I second the movement to vote. 15:56:48 +1 15:56:50 +1 15:56:59 +1 15:57:03 0 15:57:06 0 15:57:18 0 15:57:27 hmmm hard one +1 15:58:27 there is a second meeting scheduled 15:58:32 i will add the results as info 15:59:00 +1 15:59:10 #info voting results on code removal of non-XSLT views: 3x 0, 5x yes 15:59:21 moving on to another topic, hopefully easier :) 15:59:22 0 is neutral? 15:59:25 yeah 15:59:30 ah,ok 15:59:37 #topic GRS-1 removal 15:59:55 i thik we still don't have current problems with dom indexing, so this seems safer :) 16:00:02 any comments before the vote? 16:00:16 I'd like to hear from UNIMARC users 16:00:24 if they are using it, successfully 16:00:45 BibLibre customers still using grs1 16:01:10 I use dom on my dev install, but I don't play with zebra indexes... 16:01:11 have you at least evaluated DOM UNIMARC setups? 16:01:40 tcohen: yes, I think so 16:01:58 I let a note on a bug, don't remember when/where 16:02:28 "I have just install an install with unimarc + dom, it works" 16:02:32 bug 12641 16:02:32 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641 enhancement, P5 - low, ---, gmcharlt, NEW , Formally deprecate the GRS-1 indexing mode 16:02:57 #info bug 12641 16:03:09 Joubu: would you be ok with having a vote? 16:03:10 it is important to note GRS-1 has been deprecated on July 7 2014 16:03:17 *23 16:03:26 it was bug 9342 16:03:26 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9342 critical, P5 - low, ---, gmcharlt, RESOLVED FIXED, zebra UNIMARC dom indexing does not work 16:03:27 #info GRS-1 has been deprecated on July 7 2014 16:03:47 paul_p agreed last meeting, so good to me 16:03:58 ok 16:04:01 i think we can have a vote 16:04:12 so please vote on code removal of grs-1 code - making dom the only available option 16:04:17 and UNIMARC users/providers are encouraged to report any issues 16:04:17 +1 16:04:20 +1 16:04:20 good morning beautiful #koha peeps 16:04:21 +& 16:04:21 +1 16:04:28 +1 16:04:29 +1 16:04:36 +1 16:04:37 #info UNIMARC and all other users are encouraged to report any issues with DOM indexing 16:04:44 +1 16:04:53 0 16:04:54 if there are remaining issues, they should be reported before Marseille's hackfest, so we can solve them 16:05:33 #voting results on code removel of grs-1: 1x 0, 7x yes 16:05:54 #info please report before first week in march, so problems can be fixed at the hackfest in marseille 16:05:56 moving on 16:06:19 #topic Coding syntax preferences: $a->{b}{c} vs. $a->{b}->{c} 16:06:34 #info bug 13240 for discussion 16:06:34 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13240 normal, P5 - low, ---, jonathan.druart, Signed Off , advanced_notices.pl contains code obfuscation 16:07:31 I definitely prefer the second. 16:07:47 I definitely prefer the first :) 16:07:56 i don't have a preference 16:08:05 But I really don't want to discuss years about that, it's really minor, IMO. 16:08:14 i kind of agree there :) 16:08:20 0 for me 16:08:25 i think we have worse things to battle :) 16:08:26 agreed, but I also prefer the latter 16:08:41 the qustion is: is this a qa fail or are we allowing both equally for now? 16:08:52 I agree with all of the above ;-) 16:08:53 Let's us do like we want? :) 16:09:22 i think we can all adapt to either 16:09:28 we could just vote 16:09:45 what does perlcritic say about this? 16:10:07 I switched from $$a{key}{bar} to $a->{foo}{bar}. It was already a big change :p 16:10:07 please vote which you prefer: 1) $a->{b}{c} 2) $a->{b}->{c} 3) both shoudl be valid 4) no opinion 16:10:16 2 16:10:21 3 16:10:32 4 16:10:39 4 16:10:41 2 16:10:51 2 16:10:52 So we should also vote for $a->{"foo"} or $a->{foo} :) 16:11:05 nah, quotes are forbidden 16:11:07 :-P 16:11:33 agreed! 16:11:34 sorry phone 16:11:37 #chair tcohen 16:11:37 Current chairs: cait tcohen 16:11:55 more votes? 16:12:51 #voting results 1) 0 2) 3 3) 1 4) 2 16:13:04 lets see what people say on part 2 16:13:19 #info voting results 1) 0 2) 3 3) 1 4) 2 16:13:27 :-P 16:13:46 * barton promises not to vote again in the second meeting. 16:13:49 tcohen: is that in the coding guidelines? I'm not seeing it 16:14:14 shh, will write it without people noticing 16:14:52 i'll put it on next dev-meeting's agenda 16:14:53 sounds good to me 16:15:04 cait: moving on? 16:15:13 * tcohen has to leave in 3~4 minutes 16:15:23 maybe we should put the rest on the next meeting? 16:15:30 is there something really urgent on the leftover topics? 16:15:35 yes 16:15:46 I would like to talk about the test perf regression 16:15:49 I prefer 3 16:15:59 I will have some time to dedicate on that 16:16:14 + set time for a pre hackfest meeting 16:16:26 i changed my mind, we can leave the rest for the next meeting 16:16:34 could we have one next week? 16:16:37 ok for me 16:16:42 i will be travelling the week after next 16:16:43 I try 16:16:55 * tcohen has to leave 16:17:01 later guys 16:17:05 will yo u send an email tcohen? 16:17:10 with a date/time? 16:17:45 yes 16:17:45 shall we just #action him to? 16:17:46 ah :) 16:17:48 next wednesday 16:17:53 yes, action 16:17:54 please 16:18:09 #action tcohen to set date and time for next meeting - email to dev list 16:18:15 #endmeeting