13:01:09 #startmeeting Development IRC meeting 14 December 2016 13:01:09 Meeting started Wed Dec 14 13:01:09 2016 UTC. The chair is kidclamp. Information about MeetBot at http://wiki.debian.org/MeetBot. 13:01:09 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 13:01:09 The meeting name has been set to 'development_irc_meeting_14_december_2016' 13:01:23 #topic Introductions 13:01:23 #info wahanui, a bot that has become sentient 13:01:27 #info Kyle M Hall, ByWater Solutions 13:01:31 #info Marcel de Rooy, Rijksmuseum, Netherlands 13:01:34 #info Nick Clemens, ByWater Solutions 13:01:41 #info Jonathan Druart 13:01:49 #info Josef Moravec, Municipal Library Usti nad Orlici, Czech Republic 13:01:52 #info Colin Campbell, PTFS Europe Ltd 13:01:53 #info Claire Gravely, BSZ, Germany 13:01:58 #info Dimitris Antonakis, Athens, Greece 13:02:01 #info Mirko Tietgen, Berlin, Germany 13:02:14 #info Owen Leonard, Athens County Public Libraries, USA 13:03:09 last call 13:03:18 #info Petter Åsen, Oslo Public Library, Norway 13:03:24 #info Andrew Isherwood, PTFS Europe Ltd 13:03:45 #topic Announcements 13:04:02 #info George Veranis Thessaloniki, Greece 13:04:09 Mr. RM? anything form you 13:04:27 I'm starting to push enhancements to master again 13:04:32 that is all ; ) 13:04:51 #info Tomas Cohen Arazi, Theke 13:04:54 light meeting so anyone feel free to add their thoughts :-) 13:05:09 this is a judgement free zone ; ) 13:05:22 i wanted to ask 13:05:42 what is the status of the Koha::Patron implementation? we are waiting for it to complete the REST endpoint 13:05:55 is it something that will be pushed with some priority? 13:06:06 things are waiting for QA and push 13:06:33 I plan to continue the rewrite, but I need stuffs to move forward, otherwise it's to painful to maintain up-to-date 13:06:46 there's one bug that it is not easy to test, the GetBorrowersWithEmail one 13:06:53 https://bugs.koha-community.org/bugzilla3/showdependencygraph.cgi?id=16846 13:06:54 bug numbers? 13:06:57 it is trivial that it works 13:07:03 :) 13:07:10 so "green" are not really green as they need to be rebased (status=blocked) 13:07:11 but the test plan includes PKI authentication and something else 13:07:43 bug 17554 13:07:44 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Move GetBorrowersWithEmail to Koha::Patron 13:08:09 #info Koha Patron bugs should be helped along 13:08:18 tcohen: I can resubmit a test plan without that part if you like :D 13:08:30 #link https://bugs.koha-community.org/bugzilla3/showdependencygraph.cgi?id=16846 Dependencies and progress 13:08:32 why does it say persona needs to be tested, isn't that dead? 13:08:49 #link http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Bug 17554 13:08:50 04Bug 17554: enhancement, P5 - low, ---, jonathan.druart, Needs Signoff , Move GetBorrowersWithEmail to Koha::Patron 13:08:51 I had thought the same thing 13:08:58 it shouldn't be broken before we officially remove it though should it? 13:09:19 It will be shut down in December 2016 13:09:28 bug 17486 13:09:29 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 enhancement, P5 - low, ---, gmcharlt, NEW , Remove 'Mozilla Persona' as an authentication method 13:09:32 #info Barton Chittenden, BWS, Louisville, KY, USA 13:09:33 "Mozilla announced in January 2016 plans to decommission the service by the end of the year." 13:09:44 i don't think we can keep it working when mozilla kills it 13:10:37 I just mean we should work to remove it before Mozilla kills it dead, rather than just let it break by Mozilla's hand or ours. 13:10:38 I can take it (the drop) and rebase the other one on top 13:10:48 #info Magnus Enger, Libriotech, Norway 13:11:26 #action Joubu will remove Mozilla Persona and rebase his work on top 13:12:36 moving on if no more here 13:12:54 #topic Review of coding guidelines 13:13:14 nothing in the agenda but floor is open for anyone 13:13:38 ok, so, I need help on QA 13:14:09 this is about coding guidlines? 13:14:10 I'd like to talk a bit about documentation... 13:14:12 as usual, but the queue is growing too fast, I cannot maintain it alone (and don't want to) 13:14:28 developer documentation, that is... 13:14:39 if noc doing guidelines we can jump to general discussion for both of these 13:14:47 no coding 13:15:08 cait still here? 13:15:08 sounds good. let's start with the qa queue and then go to developer documentation 13:15:11 yes developer documentation could be useful 13:15:25 63 bugs in signed off queue atm 13:15:33 okay jumping 16.11 to gen disc. 13:15:41 cait is currentlly AFK 13:15:42 #topic General development discussion (trends, ideas, ...) 13:16:00 #info The QA queue is growing and Joubu needs help 13:16:15 did you mean that , Joubu? 13:16:25 in maintaining the queue 13:16:27 yes that's enough, nothing more to do about that 13:16:33 pinging ashimema 13:16:54 I pingued the QAers last week, but no answers 13:16:59 I try to QA some stuff, but have a growing backlog on my side too 13:17:16 Joubu: do you now have push rights to the master branch? 13:17:27 yes I think so 13:17:56 same boat here, working on what I can, if directed to any specific bug I am happy to make time but general QA sometimes gets missed 13:18:05 I will try to pitch in on qa. I would appreciate it if you could push anything I pass, just as a sanity check 13:18:27 khall: yep! 13:18:43 excellent, thanks! 13:19:05 I plan on testing bug 17196 in the next few days 13:19:06 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 enhancement, P5 - low, ---, jonathan.druart, Signed Off , Move marcxml out of the biblioitems table 13:20:03 2 QAs would not be superfluous 13:20:14 agreed :-) 13:20:59 I will QA it too 13:21:24 #action kidclamp and tcohen will be looking at bug 17196 13:21:44 I think the floor is yours barton 13:21:55 after barton, I'd like to highlight something 13:22:00 kk. 13:22:09 and I added something to the agenda after that :-) 13:23:11 I'd like to suggest that we make lack of developer documentation, e.g. POD, something that is an automatic failure in QA. 13:23:52 we normally should do that already? 13:23:53 I hate to put more work on the QA team, but I also hate not having documentation for everything. 13:24:15 this came up in the last meeting on November 9th 13:24:17 it's already what we do I think 13:24:45 is there a coding guideline? 13:24:46 but when the code is self-explanatory, it's not necessary useful to add pod 13:25:04 sub get_holds # well, it returns holds you know 13:25:21 barton: do you have something specific in mind? 13:25:26 perl13 13:25:36 it should be documented that it returns an array of Koha::Hold objects, though 13:25:41 :-P 13:25:48 existing rule 13:25:55 we should stress if an interface changes the change should update existing pod doc 13:26:28 https://perldoc.koha-community.org/ keep in mind it goes here too, so the code may not be immediately visible. 13:26:36 Joubu: I found that a lot of the Koha::Objects don't have any... 13:26:48 #info POD coverage should be checked during QA per coding guideline PERL13 13:28:15 #link https://perldoc.koha-community.org/ In perldoc even simple code could benefit form POD 13:28:51 it was proposed to add POD coverage to the QA script, but I don't know fi there was consensus 13:29:24 i think a minimal POD should be required on QA 13:29:33 Ok, so here's part of my quandry ... 13:29:37 at least the type of the stuff that is returned 13:29:43 harder is writing that for an interface change as mentioned by cc_ 13:29:46 so we need to decide what we want in our POD... 13:30:19 I think that there are a lot of times when the grandfather clause is used when something isn't documented... 13:30:43 I don't think PERL13 is applied appart from SearchSuggestion 13:30:51 I'd say the type for params and return values is the minimum we should require 13:30:54 a small change is made to a module that doesn't have much documentation... 13:31:20 ^^ I'm with tcohen there. 13:32:16 can we decide or should we schedule this for another meeting? 13:32:42 decide: just add this to perl13 13:32:43 tcohen: I'm fine with tabeling the discussion; I'll try and come up with some better examples. 13:33:02 I'd be interested to know what Perl Best Practices has to say on it, if anything 13:33:03 I think we need a volunteer to write the POD for existing methods 13:33:09 and be pragmatical 13:33:10 I know there is a full chapter on documentation 13:33:11 to have good examples of what we are expecting 13:33:48 Ok, I'll volounteer for writing POD. 13:33:51 yes, we need a template 13:33:59 So we wait and vote on a specific proposal? 13:34:06 * tcohen revisits his latest patches and finds incomplete PODs 13:34:07 barton: please don't be too verbose :) 13:34:16 #action Barton volunteers to write POD for existing docs, brief POD 13:34:43 anyone volunteer to work up the guidleline for POD going forward? 13:34:56 and maybe send to the mailing list to vote next meeting? 13:35:09 Joubu: I don't have enough time to write a *lot* of POD ;-) 13:35:13 I think methods from Koha namespace should be quite easy to document as they are short and do not do lot of things 13:35:21 true 13:35:37 and are covered by functional tests 13:35:39 indeed 13:35:56 There are some things that could really use it though ... holds queue, search.pm... 13:36:11 forget about Search.pm please 13:36:18 rewrite it 13:36:19 heh 13:36:20 yeah 13:36:21 we should adopt a recommended location for POD whether inline or after __END__ 13:36:23 heh. 13:36:30 inline 13:36:32 cc_: it's all inline 13:36:33 inline 13:36:36 after :p 13:36:42 no Joubu 13:36:42 Joubu-- 13:36:49 after is what PBP reccomends 13:36:53 I do not care about the doc when I can see the code 13:36:54 inline is all we do ; ) 13:37:04 inline++ 13:37:17 PBP++ :) 13:37:26 Joubu: I bet you can find a plugin for $editor that will collapse the pod ; ) 13:37:28 Joubu: if it's not inline, no one sees it and never updates it. 13:37:42 agreed 13:38:23 alright folks...I will volunteer to send something to the mailing list to add to the coding guidelines and compile issues, so fight it out there 13:38:51 #action kidclamp will send a call out to the list for POD guidelines and draft for a vote next meeting 13:39:03 is it my turn? 13:39:04 your issue tcohen? 13:39:06 yes 13:39:07 he 13:39:19 as this is a dev meeting 13:39:43 I'd like to share that I started to work on resurrecting bug 13757 13:39:44 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Make patron attributes editable in the opac if set to 'editable in OPAC' 13:40:13 the UI part was done on the bug, and so the CRUD for the opac_editable attribute for extended attributes 13:40:41 but work on borrower_modifications is missing (i.e. handling modification requests for extended attributes) 13:40:45 all this to say 13:40:59 that I got more into writing code using Koha::Object 13:41:26 trying to do a Koha::Object-ify as I touch stuff 13:41:29 aprroach 13:41:42 my first try on Koha::Object was bug 17755 13:41:42 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 enhancement, P5 - low, ---, tomascohen, Needs Signoff , Introduce Koha::Patron::Attribute::Type(s) 13:41:52 a simple one 13:42:06 that had something in common with Koha::Patron::Category 13:42:23 it is constrained by library (formerly branch) 13:42:32 #info tcohen is working on moving code to use Koha::Object 13:42:45 so i came up with Koha::Object::Limit::Library 13:43:16 which in conjunction with multiple inheritance, makes it easy to extend a Koha::Object to provide suche a constraint 13:43:25 I'd like other QAers opinions 13:43:34 on that specifically 13:43:35 should have a closer look first 13:43:38 yes 13:43:44 I like it! 13:43:45 Sounds ok to me 13:43:53 I don't expect you to do it now, just thought worth mentioning 13:44:12 and encourage you devs to give Koha::Object a try 13:44:27 because I was skeptical about it when I pushed it 13:44:30 uploads is in Koha;:Object too in the NSO queue 13:44:38 #info QA and interested parties should look at Koha::Object::Limit::Library on bug 17755 13:44:50 and now find it really handy and looking at Jonathan's work on moving stuff into using it 13:44:57 bug 17501 13:44:58 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Koha Objects for uploaded files 13:45:35 #info see work on using Koha::Object for uploads on bug 17501 13:45:36 the code looks simple to read, fast to develop 13:45:37 Joubu++ 13:45:49 it really improved my dev workflow 13:45:49 tcohen++ 13:46:02 ok, that's it. I wanted to share that I like it :-D 13:46:07 yes it's very useful for now. Some stuffs are a bit "too much". We have too many objects. And some object's responsabilities are not correctly defined 13:46:13 tcohen++ 13:46:14 and encourage people to look at the ideas behind 17755 13:46:25 but we will be able to clean that a bit when we will have more code moved to the Koha ns 13:46:28 Joubu: I agree 13:46:51 some refactoring might create weird new methods in the Koha objects 13:47:06 marcelr: yes, that's why I start with easy ones 13:47:10 marcelr: Koha::Object::Limit::Library was a try to avoid that 13:48:15 okay, I have a thing :-) 13:48:37 I would like to propose turning on voting in Bugzilla 13:48:38 https://www.bugzilla.org/docs/4.0/en/html/voting.html 13:48:51 +1 13:49:01 voting on what aspects? 13:49:12 interest/importance generally 13:49:25 I have been doing a number of talks with users who want to get involved 13:49:47 they want an easy way to mark a bug as important to them, even if they can't comment on code or implementation 13:50:00 add to cc? 13:50:03 the idea being that users can see what matters to other users and gain support for fundings 13:50:14 and devs can see where work might benefit users 13:50:16 but i do not oppose 13:50:22 adding to cc doesn't give us a count we can sort by 13:50:33 the number in the cc list? 13:50:37 and honestly, they don't all want emails 13:50:48 I don't think we can search/report that marcelr 13:51:08 the worst consequence I see would be a feature we ignore 13:51:27 * Joubu is gonna create several bz accounts to vote for his own bugs 13:51:47 heh 13:51:56 Joubu had an extra bowl of sass today 13:52:40 #info kidclamp proposes to add voting to Bigzilla 13:52:45 #link https://www.bugzilla.org/docs/4.0/en/html/voting.html Bugzilla voting 13:52:57 s/Bigzilla/Bugzilla/ 13:53:02 I don't think will get more involvement with that, but we can try 13:53:03 if there is opposition I will talk to whoever maintains bugzilla 13:53:14 will that lead to people complaining that stuff they voted on is not magically happening? 13:53:28 +1 # it won't hurt anyway, should be announced so people use it 13:53:41 if they complain and comment at least they are involved drojf :-) 13:53:46 drojf: I think the idea is to bring awareness to things everyone wants but think only they want 13:53:58 and by knowing each other, they can group sponsor work 13:54:11 +1 # just try 13:54:20 +1 13:54:22 in a magical world where they have money to sponsor :) 13:54:42 +1 # sure why not 13:54:53 hooray! thanks guys 13:55:08 is it on now? kidclamp ? 13:55:11 lol 13:55:38 hah, I think I have to ping rangi, I think catalyst maintains bz 13:55:45 drojf: power in numbers, just had a development sponsored by 30 something libraries pitching in very small amounts 13:55:58 +1 from me as well 13:56:01 kidclamp: yes, better do it via rangi 13:56:05 #topic Updates from the QA team 13:56:13 khall: nice! 13:56:26 anything more to add? I think we covered it in discussion 13:56:55 yes just 13:57:00 not QA related 13:57:05 :-) 13:57:12 but ldap seems broken under plack 13:57:27 possibly shib/SAML too 13:57:27 on the general Koha ML 13:57:40 I quickly looked at the code C4/Auth_with_ldap 13:57:53 and it has wrong var scope 13:58:08 someone knowing this part of code should get a look 13:58:17 I can varify shib is broken under plack 13:58:17 it may be easy to fix 13:58:26 and I have a plan to fix it.. when I get a moment 13:58:42 ldap I wasn't aware of being broken. 13:58:55 * kidclamp hands ashimema all of his round tuits 13:58:57 edi libary ean is broken too 13:59:02 you can't add any 13:59:03 ashimema++ 13:59:14 shib is a case of switching from env variables to request headers 13:59:14 qa is no longer my topic, but from rmaint's point of vie 13:59:14 w 13:59:17 we have ldap working under plack in 3.22 in at least one instance 13:59:26 cait: is there a bug number for that? I'd be happy to fix it 13:59:33 yes of course 13:59:46 there are lots of open bug reports waiting for patches - please also take a look at those. I am going to call string freeze tomorrow and then release on 22nd 13:59:59 it would be really good if dev coudl take a look at the blocker - major ones recently filed 14:00:07 bug 17692 14:00:18 #info LDAP and shib may not be entirely plack safe 14:00:37 bug 17764 is evil too 14:00:38 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17764 critical, P2, ---, oleonard, NEW , OPAC search fails when lost items are in the result set and there is no logged in user 14:00:42 #topic Progress on next release (16.11) 14:00:44 OPAC search fails when lost items are in the result set and there is no logged in user 14:00:51 #info there are lots of open bug reports waiting for patches - please also take a look at those 14:00:59 #info string freeze on the 22nd 14:01:04 17764 is for me 14:01:17 it would be great if we could still get those into 16.11.1 14:01:24 * oleonard runs off to an irl meeting 14:01:34 #info bug 17692 and bug 17764 are high priority for 16.11.1 14:01:39 * ashimema apologises for having missed most of this meeting.. feeling rough so went back to bed and slept through the alarm 14:01:43 oleonard++ 14:01:52 ther are more, those i remembered off the top of my head 14:02:10 any relation with bug 17502 14:02:11 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 normal, P5 - low, ---, m.de.rooy, Needs Signoff , Resolve internal server error on 0000-00-00 (with Plack) 14:02:32 also a failing search 14:02:32 cait: could you send me the list, if you have one? 14:02:58 anything more cait? 14:03:01 i can try and create one - maybe by tomorrow? 14:03:14 there is also a fixme now search on bugzilla 14:03:17 that cvould be helpful 14:03:24 #action cait will compile a list of bugs wanted/needed for 16.11.1 14:03:51 hm where could we put those so it's not just me? 14:04:02 send to koha/koha-devel 14:04:37 also some problems with mulitple holds and sip i think 14:04:55 there is always lots of bugs - so please don't hit me if i miss an important one 14:05:12 #info don't hit cait 14:05:12 i will check what i held back i my inbox - but can't go look through all of bugzilla 14:05:25 bug 17775 14:05:26 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 blocker, P5 - low, ---, gmcharlt, NEW , Add new user with LDAP not works under Plack 14:05:34 yeah, some evil plack things around 14:05:38 cait: 17502 14:05:44 #topic Set time of next meeting 14:06:15 I am proposing something around 20UTC according to survey until someone has a better method/time 14:07:11 +1 14:07:25 January 11, 20UTC? 14:07:49 we should have 2 dev meetings a month 14:07:49 Wed 14:07:50 brief ones 14:08:07 this was a good time btw 14:08:14 agreed. 14:08:25 agreed, this time was nice 14:08:38 tcohen - I am all for it if somone else will chair the second meeting 14:08:54 * tcohen volunteers 14:09:01 but keeping meeting short is harder than I thought :-) 14:09:12 I'll ask for help if i cannot attend 14:09:16 true 14:09:27 kidclamp++ 14:09:37 #action tcohen proposes to hold a second dev meeting - he will chair 14:10:00 do you want to set a time now tcohen, 2 weeks or so? or wait until January to being? 14:10:03 begin 14:10:18 wait until january, because end of the year is complicated for everyone 14:10:26 sounds good 14:10:51 #info next meeting 11 January 2016, 20 UTC 14:11:02 #endmeeting