20:04:57 #startmeeting Development IRC meeting 23 May 2018 20:04:57 Meeting started Wed May 23 20:04:57 2018 UTC. The chair is kidclamp. Information about MeetBot at http://wiki.debian.org/MeetBot. 20:04:57 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 20:04:57 The meeting name has been set to 'development_irc_meeting_23_may_2018' 20:05:03 #topic INtroductions 20:05:03 #info wahanui, a bot that has become sentient 20:05:13 #info Jon Knight, Loughborough University 20:05:14 #info Nick Clemens, ByWater Solutions 20:05:29 #info Brendan Gallagher, ByWater 20:05:33 #info Lee Jamison, Marywood University 20:06:13 #info Katrin Fischer, BSZ, Germany 20:06:14 is this kidclamp_Awya east coast language? 20:06:35 aw yeah boi! 20:06:49 bag: hey now..no picking on east coasters :P 20:07:03 * bag is an east coaster :D 20:07:12 #topic Announcements 20:07:22 anybody? 20:07:22 The #koha IRC channel is populated by people from many timezones, sometimes even on weekends. However, if no one is here right now and you need help you should take a look at http://koha-community.org/support/ 20:07:35 wahanui: botsnack 20:07:35 thanks kidclamp :) 20:07:48 documentation for 18.05 will be completed by the weekend :) 20:08:20 #info documentation for 18.05 will be completed by the weekend :) 20:08:25 I've been doing a spot of background bug wrangling by looking at "old" (> 5 year old) bugs 20:08:37 greenjimll++ 20:08:44 greenjimll++ 20:09:26 Some of the old bugs are duplicates, some need nudging and others could probably be subsumed into more modern developments. A long term task! 20:09:29 LeeJ++ 20:09:40 greenjimll++ 20:09:42 #info greenjimll (and a few others) have been cleanign up old bugs - thanks to all! 20:10:12 #topic Update from the Release manager (18.05, 18.11) 20:10:13 I've been working on permission bugs 20:10:19 too late heh :) 20:10:27 you gotta be quick! 20:10:31 go on :) 20:10:39 heh, go ahead if more notes though 20:11:07 No Joubu - he is awaiting stable releases with sec patches before release - they should be set tomorrow 20:11:12 not really :) 20:11:20 Joubu++ 20:11:24 #info Release is awaiting stable releases 20:11:42 #info Stable releases had an issue with a security patch, should be cleared now and releases coming shortly 20:12:21 #info Future RM looks forward to making all your Koha dreams come true, let kidclamp know your concerns for this release if you have them 20:12:35 I get to wear lots of hats today! 20:12:38 kidclamp++ 20:12:48 #topic Updates from the QA team 20:12:52 cait? 20:12:52 i heard cait was the best friend you could ever have. 20:13:03 wanahanui: botsnack pizza! 20:13:13 ah oops 20:13:37 QA has been a little slow right before the release 20:13:40 but we will pick up again soon :) 20:14:07 #info QA is gearing up to pass all the bugs, clean your queues now! 20:14:14 yesterday it was 70 in the queue, today is 83... so yep we will have to 20:14:29 #info Tomas Cohen Arazi, Theke Solutions 20:14:38 QA team is also 2 more members 20:14:38 okay, cait. 20:14:44 so I hope we can empty the queue out ;) 20:15:09 cait: and then we'll fill it up with new patches. :-) 20:15:24 i'll call that a challenge :) 20:15:53 #topic General development discussion (trends, ideas, ...) 20:16:02 bug 2619 20:16:02 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2619 normal, P3, ---, gmcharlt, NEW , Turning on XSLTResultsDisplay preference turns off item detail display 20:16:21 that turned up in my old bug clean-up 20:16:32 i was wondering if we could deprecate the feature as it was never implemented for XSLt 20:16:45 and we are trying to get rid of the non-xslt (deprecated them quite a while ago) 20:17:28 https://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR1:_non-XSLT_search_results_and_bib_display_templates_deprecated 20:18:05 ~4 years of waiting? I think we can remove this 20:18:15 any dissent? 20:18:19 #info Martin Renvoize, PTFS Europe 20:18:32 or discussion? 20:18:32 i guess discussion is always constructive :) 20:18:33 hm 20:18:43 kidclamp: let's trim the fat! 20:18:48 Haha.. deprecate all the things 20:18:53 Joubu already wrote the patches, for sure 20:19:05 its been deprecated for several years 20:19:22 If its been deprecated for years already, nuke it from high orbit. 20:19:25 I'm sure someone is still using it, on an unsupported OS 20:20:08 tcohen: let's not forget most likely an unsupported Koha version too 20:20:09 push for this release and send out a note on the mailing lists and make sure it gets in release notes? 20:20:17 hm not sure reading again if i read the bug correctly 20:20:59 i will recheck and move it forward accordingly 20:21:14 it actually seem to do something with xslt... but not work right? 20:21:37 kidclamp: speaking of release notes...the docs team would greatly appreciate release notes on new features/enhancements..just a friendly reminder :) 20:21:51 the actual issue is with OPACItemsResultsDisplay i tihnk 20:22:10 but no big push against, so let's move forward with working towards no-xslt removal :) 20:23:09 If we get rid of the non-xslt output, there won't be anything to compare the output against so bug 2619 will disappear. :-) 20:23:09 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2619 normal, P3, ---, gmcharlt, NEW , Turning on XSLTResultsDisplay preference turns off item detail display 20:23:31 heh 20:23:32 greenjimll: +1 heh 20:23:34 moving on? 20:23:40 yep 20:24:32 #topic API: account lines RFC, possible vote. 20:24:35 tcohen, 20:24:35 i guess tcohen, is there a bz where i can send a patch or should I create a new one ? 20:25:02 I just wanted to hear opinions on that RFC 20:25:10 wahanui tcohen is that guy with the great hair 20:25:10 ...but tcohen is obsessed with packages' scripts|122|obsessed with automated testing :)|king of the lab... 20:25:16 wahanui tcohen is also that guy with the great hair 20:25:16 okay, kidclamp. 20:25:27 tcohen++ for moving on with REST API 20:25:30 * ashimema feels bad he's not read the RFC yet 20:25:40 i made a small comment below and a small correction with on eof the db fields 20:25:45 I've basically worked with bug 15165 as a basis 20:25:45 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 enhancement, P5 - low, ---, alex.arnaud, In Discussion , REST API routes to list, edit and pay borrower's accountlines 20:25:45 RFC link? 20:25:45 but have to think about it properly still 20:25:58 trying to make it REST-ish 20:26:07 #link https://wiki.koha-community.org/wiki/Patrons_account_lines_endpoint_RFC Accounts API proposal 20:26:15 thanks kidclamp 20:26:42 i'm missing to add the object definitions for 20:26:51 the /credits and /debits endpoints 20:26:56 are there 2 or just both linked to the same page? 20:27:02 https://wiki.koha-community.org/wiki/REST_api_RFCs 20:27:13 which will of course resemble the /account/lines endpoint objects 20:27:14 he 20:27:19 there's only one page 20:27:20 there is also /acount and account/lines 20:27:24 in the table 20:27:34 all point to the same place 20:27:44 I wanted to put it all together for context 20:28:25 so 20:28:33 there's a discussion I proposed on the RFC 20:28:44 because we *could* prefer to have 20:28:58 At first glance looks solid to me.. will have a more in depth read tomorrow when I'm more awake 20:29:01 - …/payments and …/writeoffs 20:29:14 - …/fees and …/fines 20:29:34 I picked debits and credits to avoid constraining it 20:29:49 is a writeoff not a void? 20:29:58 i.e. /credits implies some credit_type => 'payment' needed 20:30:08 a writeoff is a writeoff 20:30:09 he 20:30:11 kidclamp: i tihnk void is a mistake, writeoff is forgiving 20:30:16 as I understand it, you are right 20:30:16 ah so /credits type=>writeoff 20:30:25 but Koha stores it as a credit, yes 20:30:28 i think the intention is different 20:30:31 kk, too much sun today 20:30:51 I've been thinking about some of the GDPR stuff (bug 20028 for example) and this REST API may be useful for grabbing patron account information for that. 20:30:51 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 enhancement, P5 - low, ---, koha-bugs, NEW , Export all patron related personal data in one package 20:30:51 void is DELETE /account/lines/{account_line_id} 20:31:13 admittedly, I don't like to delete anything, too many questions :-) but the logs should cover that case 20:31:20 having rest apis for everything would make it much easier to do the 'download all data you have stored about me' button 20:31:30 the DELETE action doesn't delete anything actually 20:31:31 cait++ 20:31:50 it calls $accountline->void which sets everything to zero and stamps a 'VOID' type in some places 20:32:04 then GET /account/lines won't show them by default 20:32:11 i tihnk a writeoff is: we don't take the money, but it was a real fine and it's counted as such 20:32:11 as they didn't exist 20:32:27 while voiding would be used to correct a mistake 20:32:28 writeoff is forgiving 20:32:41 making void is cancelling a credit (payment) 20:33:01 i think you will be able to void a writeoff too? 20:33:02 So a writeoff is a 100% discount on a fine? 20:33:02 didn't mean to derail 20:33:09 ok, it's complicated 20:33:10 cait: yes 20:33:23 greenjimll: in the code, yes 20:33:27 so 20:33:38 All sounds sensible to me 20:33:45 please comment on the wiki about the /debits /credits discussion 20:34:03 I will finish the object definitions during the week, to schedule a vote for next meeting 20:34:03 so no vote today? 20:34:14 #info please follow the link and read and comment on the rfc 20:34:14 no need to, I am already working on this anywya hhe 20:34:23 do we want to vote for next meeting? 20:35:31 next friday so I have my RFC voted 20:35:34 #keeding 20:35:42 +1 20:35:59 +1 20:36:03 +1 20:36:14 +1 20:36:33 +1 20:36:54 okay, work ahead and add to next meeting tomas 20:37:28 #topic Review of coding guidelines 20:37:35 Anything here? 20:37:51 not from me 20:37:55 nor me 20:38:04 #topic Set time of next meeting 20:38:09 2 weeks? 20:38:09 i guess 2 weeks is not good nor bad, but thinking makes it so. 20:38:29 would be same day as general 20:38:39 yep 20:39:04 June 13th - 14 UTC? 20:39:26 either day is good for me 20:39:34 whoops 20:39:38 library conf here 20:39:38 read it wrong 20:39:43 that works for me 20:39:44 * kidclamp prefers less meetings per day 20:39:45 but i will leave notes on the wiki if necessary 20:39:49 cait++ 20:39:57 going once...twice... 20:40:12 sold! *slams gavel* 20:40:13 tcohen: For GET /account/lines (and maybe other endpoints) is there a way of limiting the responses to a date range? 20:40:19 #info Next meeting: 13 June 2018, 14 UTC 20:40:30 #endmeeting