14:08:29 #startmeeting Development IRC meeting 14 October 2015 - part 1 14:08:29 Meeting started Wed Oct 14 14:08:29 2015 UTC. The chair is tcohen. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:08:29 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:08:29 The meeting name has been set to 'development_irc_meeting_14_october_2015___part_1' 14:08:39 #topic Introductions 14:08:40 #info wahanui, a bot that has become sentient 14:08:45 #info Tomas Cohen Arazi, Theke Solutions 14:08:49 #info Nicole C Engard, ByWater Solutions 14:08:58 please introduce yourselves like that ^^^^ 14:09:03 #info Julian Maurice, BibLibre 14:09:08 #info Colin Campbell PTFS-Europe 14:09:15 #info Kyle Hall, ByWater Solutions 14:09:23 #info Andreas Hedström Mace, Stockholm University Library 14:09:28 #info Barton Chittenden, ByWater Solutions 14:09:28 Brendan Gallagher ByWater 14:10:21 will wait one more minute 14:10:46 #info Brendan Gallagher ByWater 14:10:59 #info Katrin Fischer, BSZ 14:11:49 time 14:11:50 #topic RM 3.22 comments 14:12:25 #info Jonathan Druart 14:12:32 first of all, I want to apologize for the lag on the PQA queue 14:12:59 it has become more and more difficult to keep the pace on such big developments 14:13:03 tcohen++ looking better then the NQA ;) 14:13:22 testing them and making sure everything is ironed for the users worldwide 14:13:31 and having a life appart from that 14:13:32 heh 14:13:58 tcohen I thought RMs weren't allowed to have lives? ;) 14:14:05 I'm happy with how things have been doing overall, but I know it is frustrating to see 14:14:17 tcohen++ 14:14:18 your work lag even when it was perr-review by several people 14:14:32 i think that will happen, always 14:14:47 because the RM position is very demanding 14:15:06 and it should be (somehow) funded so people can do it full time 14:15:23 just my two cents for the project's future 14:15:32 Here hear 14:15:40 tcohen++ 14:15:48 Trying for that we are 14:15:49 tcohen++ 14:16:06 by 'funded' I mean that support companies should bring someone from their team to do it on work-hours 14:16:25 or whatever suits the community's possibilities at some point 14:16:40 btw, agenda at http://wiki.koha-community.org/wiki/Development_IRC_meeting_14_October_2015 14:16:47 i'm not complaining at all, I really enjoyed this, but it got more difficult than I expecetd 14:16:52 so 14:17:04 that was the "RM" bit 14:17:15 now the "3.22 comments" part :-P 14:17:45 some big stuff has been pushed recently 14:18:14 file-upload capabilities and refactoring 14:18:26 #info Marcel de Rooy 14:18:32 OAI implementation changes 14:18:51 bug 14321 14:18:52 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 enhancement, P5 - low, ---, m.de.rooy, Pushed to Master , Merge UploadedFile and UploadedFiles into Koha::Upload 14:19:21 that one requires ironing the deployment: i.e. we need to set a default upload_path 14:19:28 bug 14893 14:19:29 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Separate temporary storage per instance in Upload.pm 14:19:57 overall things are pretty stable, even though jenkins is failing 14:20:22 #info tcohen asks patch authors to take care of things being broken on jenkins, might be your fault! 14:20:47 anyway 14:21:13 I repeat myself, but we need more teseting on koha-plack, that's the purpose of teh kohadevbox:ansible branch 14:21:30 Jonathan has been working on a couple problems we found 14:21:35 Joubu++ 14:21:36 #link http://wiki.koha-community.org/wiki/Development_IRC_meeting_14_October_2015 14:21:40 Joubu++ 14:21:59 but the fact is that we are a month and a half away from the release and there is no evidence 14:22:11 people have been testing the plack integration on the packages 14:22:18 bug 15005 14:22:19 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 major, P5 - low, ---, jonathan.druart, Needs Signoff , (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs 14:22:34 back 14:23:17 #info bug 15005 is really tricky to solve, with possible integration issues, and requires expert eyes 14:24:22 we have enough time to iron things out, but we will need to focus on this things 14:24:51 #action tcohen volunteers to help people set a suitable test environment for anywant willing to spend a couple minutes testing plack 14:24:56 stress session? 14:25:02 ah, that 14:25:02 ah, that is just to say that everything should be on one line 14:25:45 #info ByWater has provided a VM with external access, in which we will set a Koha+plack install so we can do stress tests on it 14:25:50 bywater++ 14:26:03 questions? 14:26:04 questions are good :) 14:26:09 when? 14:26:22 i can set everything up tomorrow morning 14:27:04 #action tcohen will send an email to the devel list with data about the koha-common+plack server 14:27:09 we need as many people as possible, to simulate a normal circulation/search/etc. workflow 14:28:06 questions about 3.22? 14:28:10 It would be preferable to push 15005 before the stress session 14:28:53 yes, do you plan to push the ES work? 14:28:58 Joubu: I didn't realized you already provided the needed followups for ->url 14:29:01 and bug 11559? 14:29:02 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 enhancement, P5 - low, ---, jweaver, Needs Signoff , Professional cataloger's interface 14:29:14 and the REST api "base" 14:29:15 Would love to see ^^ in 3.22 14:29:28 us too 14:30:02 I tested it and it has issues, but it can be pushed as it is an opt-in, once it gets PQA 14:30:08 (rancor) 14:30:09 I need to know the priorities to focus my work for the next month 14:30:39 I don't think the ES work will make it 14:30:46 imo ES needs more testing, I’ve tested it and I’ve got it set up, 14:31:07 I think the REST work should be pushed if we generate the needed patches for integrating with the packages 14:31:27 that's my opinion 14:31:32 bug number for need patches? 14:31:43 bug 13799 14:31:44 it has been said that bug 13799 is ready to go in master, if nobody complains about it 14:31:44 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 new feature, P5 - low, ---, julian.maurice, Failed QA , Add base for building RESTful API 14:31:54 I have not willing to see 13799 pushed without any guidelines 14:31:57 I welcomed ashimema's followups, I guess we just need to solve minor issues right now 14:32:09 :) 14:32:14 I thing we need to see discussion (yes again) on bug 14974 before 14:32:15 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 enhancement, P5 - low, ---, jonathan.druart, In Discussion , Use the REST API for cities 14:32:32 ooh.. meeting.. 14:32:32 meeting is probably in two days, i thought was tomorrow. plenty of time then 14:32:34 oops 14:32:35 ashimema++ 14:32:46 #info Martin Renvoize - PTFS Europe 14:33:27 agree with Joubu.. we're getting there with the rest stuff.. but I'd like to see some concrete examples and guidlines around implimenting controllers for it 14:33:30 I think ashimema's comment on 13799 should be the basis for those guidelines 14:33:35 so we get adoption going. 14:33:46 code please! 14:33:51 I know khall, joubu and I are all working on some examples 14:34:15 mine is submitted, I don't plan to do more 14:34:22 * ashimema goes off to remind himself of the comment 14:34:27 :) 14:34:45 I'm trying to find some time for my angualr guy to attack it 14:35:16 so you think we need guidelines on how the UI should use the REST api to accept it pushed? 14:35:37 (definitely) 14:35:41 or just guidelines on how to build the controllers? 14:35:44 not exactly.. I'd love to see some.. 14:36:17 but I do think we need some clear guidelines on how controllers should be coded.. or rather spec'd 14:36:20 i don't think we need more than guidelines on the controllers code 14:36:36 it's important to build good specs with swagger.. else allot of the 'win' from using it is lost.. 14:36:41 I'd like to see alternative patches suggested on 14974, to do exactly the same things as mine 14:36:47 becuase otherwise we should make a decision on the UI tools (angular?) before we can have a REST api 14:36:58 the current specs are too sparse in terms of the requests and responses are not schema'd up.. 14:37:21 what's the point to have a "rest api base" if we don't know how to use/improve it? 14:37:23 i.e there is currently no validation going on before and after the controller code runs to varify what you 'think' you are getting in is what you actually are.. 14:37:26 and vica versa 14:37:57 UI wise, i think that's the next step.. hopefulyl closely behind.. 14:38:04 Better than specs, I'd prefer some code 14:38:35 I think getting the server level into master sooner rather than later good.. but also think before full release we need the ui examples and documentation in too 14:38:40 does that make sense 14:39:54 if we had a technical comitee, with schedules to make decisions I'd say we should wait for that 14:40:05 but we don't, we make decisions in places like this meeting 14:40:20 and mostly with code, provided by people that actually work on the implementations 14:40:47 that’s so true 14:40:55 catch 22 14:41:26 i'm happy with extracting martin's comments on how we should split the swagger file, and his guidelines on the types we need to choose for things 14:41:43 and consider that, and Julian's implementation something close to a guideline 14:41:48 seems reasonable 14:41:53 but I accept that we might not agree on that 14:42:22 I read Jonathan's implementation, and if it complied with martin's recommendation, I'd push it too :-P 14:42:32 well, I'm not sure about the UI part 14:42:41 but the controller and backend, yes 14:43:52 Where is Julian's implementation? 14:43:53 I'll close this topic, as we moved to the next one (REST :-D) 14:44:30 but first, I'd like to set feature slush for 23rd October 14:45:52 questions about feature slush 14:45:53 ? 14:46:06 In the bug reports linked to the "api base" I don't see a guideline on how using the REST api from Koha scripts 14:46:48 it's pretty soon :) 14:47:23 how do you explicitly define feature slush ? 14:47:54 the point were things that things that are not PQA are not *elegible* for poshing 14:47:58 I'll post the promised followups ot the rest bug shortly 14:48:01 just writing them now 14:48:12 sweet thanks ashimema 14:48:15 (found a bug in swagger2 lib which i'm fixing first.. hense the slow down) 14:48:28 So we need everything that is signed off passed qa by the 23rd or else it won't be in 3.22? 14:48:30 Got it 14:48:45 no this is about new features only 14:48:48 * ashimema has been writing tests furiosly for the Mojo Swagger2 lib the past few weeks.. to make sure feature we are using don't go away ;) 14:49:06 feature slush good :) 14:49:17 oh good to know marcelr 14:49:31 i'm moving it November 26th, because people tend to work hard before the feature slush, and no point setting it to a friday when I'm not going to have time to push things 14:49:32 tcohen: and enhancements? 14:49:45 ashimema++ 14:49:50 ashimema++ 14:50:03 October 26th i guess 14:50:13 ah, yes, thanks marcelr 14:50:26 #info feature slush is October 26th 14:51:19 marcelr: I'm not sure, I guess small enhancements are not a problem, those that look more like a feature are 14:51:38 clear enough 14:52:11 in the end, it will depend on how much time I can spend on this, because I will be focusing on ironing things 14:52:27 unless people start seriously testing and let me spend more time pushing :-P 14:53:02 the next topic is the REST api implementation 14:53:13 #topic RESTful API Implementation 14:54:05 tcohen: you can count me in #testing 14:54:12 about bug 13799, I expected that Julian and Martin explained us the implementation details/decisions, and then Martin's followups, with the aim to have a general idea of those guidelines 14:54:13 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 new feature, P5 - low, ---, julian.maurice, Failed QA , Add base for building RESTful API 14:54:23 thanks Joubu 14:55:15 is there any volunteer that could extract that information from the bug so we start a wiki for those "guidelines"? 14:55:34 and code? :) 14:55:45 what guidelines are we looking for? 14:55:56 to add new services to the api, using the api, or both 14:56:07 both 14:56:11 my opinion is that we need the first 14:56:22 as mandatory 14:56:25 agreed. 14:56:35 I can write some guidelines based around using the swagger stuff meaningfully 14:56:37 we don't even have angular pushed to master 14:56:42 and write some examples too 14:56:48 I'll create the wiki page if ashimema and Joubu can go through and tweak it 14:57:03 back... 14:57:09 the clientside I'm less up to speed on and am honestly not entirely sure of the best aproach as yet.. 14:57:38 khall: I have no idea on how to use it and I am not involved in the discussion from the beginning, so not me :) 14:57:40 agreed, the backend is far more important at this point 14:57:43 the guidelines should cover: 14:57:49 would like to see some angualr based stuff sooner rather than later.. and to see some non-blocking async calls going on.. we're really nto very good at async calls yet 14:57:54 Joubu: np! 14:58:03 - how to structure the controller scripts 14:58:16 - how to make decisions on the endpoint naming, etc 14:58:18 ashimema: a wiki page on that would be good 14:58:21 k.. khall and I will tag team writing that page :) 14:58:24 - how to organize the swagger files 14:58:25 with good and bad examples 14:58:34 certainly ;) 14:58:57 we have some nasty blocks in the few places (the patrons search page in the staff cleint is very blocky currently) 14:59:14 I'll do the controllers + swagger guidlines first.. 14:59:32 then move onto utilising them clientside (with help of my tame angular dev) 14:59:47 ashimema: that sounds most excellent 15:00:07 :) 15:00:20 #info Jonathan worked on his own REST implementation test-drive on bug 14974, please, Mojo/Swagger/REST experts take a look and provide feedback 15:00:21 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 enhancement, P5 - low, ---, jonathan.druart, In Discussion , Use the REST API for cities 15:00:28 sorry guys.. my auth maintainer hat is beign put down for a while whilst this api stuff goes through the motions ;) 15:00:37 only so many hours in a day 15:01:03 :) 15:01:26 ashimema: we forgive you, if you help us have those guidelines :-D 15:01:49 hallo 15:02:15 pianohacker: just in time, we said next one to login was the volunteer 15:02:21 uh oh 15:02:28 lol 15:02:33 volunteer for what? Finishing full port to dbic? 15:02:46 :) 15:02:59 * ashimema would love full dbic port.. (and a cleaner db schema to boot) 15:03:04 pianohacker: yes, but we need a full rewrite of all the things too, thanks for volunteering! 15:03:09 oh, cool 15:03:13 in perl 6 of course 15:04:12 pianohacker: yes, but needs to be backwards compatible 15:04:23 with python? Can do! 15:04:26 back to perl 5.6 15:04:44 man, I thought you were volunteering me for something HARD 15:04:45 ok, so can I put actions? 15:05:37 go for it 15:06:10 #action Kyle volunteers to start a wiki page for the REST guidelines 15:06:10 #action Martin volunteers to polish some Controller / Swagger guidelines for the REST implementation 15:07:15 and code/example, someone? 15:07:58 * Joubu has the impression that he is repeating himself 15:08:03 action pianohacker volunteers to take a look and comment on 14974 15:08:07 :-P 15:08:22 good to know! 15:08:34 if you accept I'll add the dash 15:08:42 yes 15:08:45 oh yeah can do 15:08:49 #action pianohacker volunteers to take a look and comment on 14974 15:08:52 excellent 15:08:57 pianohacker++ 15:09:40 ashimema: please comment on anything you need, or whatever I/we can help with regarding the docs 15:10:09 and thanks 15:10:22 moving on 15:11:24 will also try to do some code example Joubu.. to go with the docs 15:13:16 sweet 15:15:50 :) 15:16:58 ok, sorry, had my boss asking me about my work :-/ 15:17:07 (DSpace things) 15:17:26 #topic 'Big stuff we are working on' 15:17:36 tcohen: You don't do anything at work, just surfing on facebook, everybody knows that 15:17:43 yeah 15:17:54 * tcohen seriously things his boss belives so 15:18:42 so.. Bug stuffs? 15:18:49 s/Bug/Bug 15:19:14 Working on rancor atm, but I think that's already been discussed 15:19:15 * tcohen suspects the guidelines will be full of typos 15:19:23 :-P 15:19:24 HA 15:20:16 pianohacker: yeap 15:20:25 ok, moving on 15:20:34 #topic Specific bugs that need feedback 15:21:14 #info please take a look at tests failing on jenkins, specially if your patches might be guilty 15:21:42 tcohen: at least one of the jenkins build failures seemed to be due to DB connection issues 15:21:43 I'd also like to ask the QA team to give packages-related patches some priority 15:22:10 * ashimema is terrible at holding conversations in multiple windows and managing to stave off the typo's too 15:22:11 pianohacker: thanks, will check (on that free time I have heheh) 15:22:19 * Joubu missed the big bugs stuffs... 15:22:32 Joubu: only rancor was mentioned 15:22:40 we absolutely need to test 13618 15:22:40 would you like to add something? 15:22:45 because I won't rebase it for months! 15:22:47 tcohen: you find any of that "free time" stuff, make sure to share your source 15:22:51 bug 13618 15:22:51 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 normal, P5 - low, ---, jonathan.druart, Needs Signoff , Prevent XSS in the Staff Client and the OPAC 15:22:54 tcohen: silly question, but where do I look to see if one of my patches has broken jenkins? is 'prove' enough? 15:23:07 and I have provided a quick patch on bug 14778, because it was blocker for everybody 15:23:08 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 normal, P5 - low, ---, jonathan.druart, Failed QA , Get rid of DBIx::Connector 15:23:11 now there is a patch 15:23:15 and nobody cares 15:23:20 barton: there's a link in the email that takes you to the jenkins site, and you can see the test output there 15:23:53 jenkins is sending emails to patch authors since it started failing 15:24:06 it doesn't know what patch broke things 15:24:15 (i.e. is not bisecting the git repo) 15:24:31 Joubu: how sure are we that bug 13618 covers all the areas that output HTML? 15:25:06 Joubu: and I think everyone very much cares but has no idea what is wrong 15:25:07 no way to know 15:25:33 bye 15:25:59 if we don't manage to make DBI::Mock works, since kick it out 15:26:04 s/since/then 15:26:13 Joubu: I agree 15:26:38 does TestBuilder at least partially remove the need for it? 15:26:52 ye 15:26:53 yes 15:26:56 hmm 15:27:01 say yes 15:27:04 more or less 15:27:07 I think there is a conflict 15:27:24 but the tests using the DB Mock are not very useful 15:27:41 because TestBuilder is used for 'integration tests', in the sense that they need data on the DB, and things like that 15:27:59 Unit tests on t/ should actually mock everything+} 15:28:28 the fact that we are reaching DBIx::Class on some tests that are mocking DBI, is a symptom that we have mixed things too much 15:28:36 the tests using it could cover more use cases if they were DB dpes 15:28:37 deps 15:28:53 I'd say we shouldn't be using DBI::Mock on t/db_dependent 15:28:58 there's only 6 tests that use DBD::Mock, but 4 of them (Koha, Biblio, Calendar and Members/cardnumber) are non-db-dependent 15:29:14 pianohacker: did you test the patchset on a customer's server? 15:29:15 * ashimema is catching back up 15:29:57 Joubu: no, the site where we were experiencing issues has gone quiet for reasons we don't entirely understand :/ 15:29:58 pianohacker: I have much more occurrences 15:30:02 t/Acquisition/Invoice.t for instance 15:30:29 pianohacker: every test file that uses t::lib::Mocks 15:30:39 ohhhh, shoot. 15:30:49 the problem is mixing things 15:32:08 Johnster 15:32:46 ok 15:33:13 #info 14778 is very important and needs urgent feedback 15:33:26 Note that it's not important for me :) 15:33:30 also on my todo pile is that bug ;) 15:33:40 'tis for me 15:33:43 I'm just happy that I got an install up and running--with one notable exception! 15:34:02 but need to get the customers test server up to date before I can get them to test it 15:34:34 thanks ashimema 15:34:55 o/ 15:35:34 ok, I think it is time to move on 15:35:51 #topic Set time of next meeting 15:36:30 #info there will be at least one more dev meeting, tcohen might call for a topic-specific dev meeting if there is something urgent that needs feedback 15:36:57 #info please communicate fluently regarding bugs and things that might hit the next release 15:37:50 thanks everyone for attending and specially for volunteering, you all rock 15:38:03 thanks tcohen 15:38:05 #endmeeting