============================================= #koha: Developer IRC Meeting, 2 February 2016 ============================================= Meeting started by cait at 15:01:10 UTC. The full logs are available at http://meetings.koha-community.org/2016/developer_irc_meeting__2_february_2016.2016-02-02-15.01.log.html . Meeting summary --------------- * Introductions (cait, 15:01:18) * wahanui, a bot that has become sentient (wahanui, 15:01:18) * Katrin Fischer, BSZ, Germany (cait, 15:01:39) * Owen Leonard, Athens County Public Libraries (oleonard, 15:01:46) * Jesse Weaver, ByWater Solutions, USA (pianohacker, 15:01:52) * LINK: https://wiki.koha-community.org/wiki/Development_IRC_meeting_2_February_2016 (cait, 15:02:02) * Joy Nelson, ByWater Solutions, USA (talljoy, 15:02:05) * Julian Maurice, BibLibre, France (jajm, 15:02:16) * Jonathan Druart (Joubu, 15:02:18) * Matthias Meusburger, Biblibre, France (matts, 15:02:25) * Marcel de Rooy, Rijksmuseum, Netherlands (marcelr, 15:02:32) * Andreas Hedström Mace, Stockholm University Library (andreashm, 15:02:35) * Brendan Gallagher ByWater (bag, 15:02:50) * Colin Campbell, PTFS-Europe (cc, 15:03:03) * Nick Clemens, ByWater Solutions, USA (kidclamp, 15:03:30) * mirko tietgen, not really here (drojf2, 15:03:37) * Tomas Cohen Arazi, Theke (tcohen, 15:03:55) * Kyle M Hall, Bywater Solutions (khall, 15:04:28) * Nate Curulla, BWS (NateC, 15:04:29) * XSS patches were pushed, please test and help to find any remaining problems (cait, 15:06:23) * Indranil Das Gupta, L2C2 Technologies (indradg, 15:07:20) * Elastic search needs testing as well - please use the branch on the main repository (cait, 15:07:31) * LINK: https://wiki.koha-community.org/wiki/Elasticsearch (cait, 15:08:31) * Elastic search branch: remotes/origin/new_12478_elasticsearch (cait, 15:08:54) * Review of Coding guidelines (cait, 15:09:30) * [marcelr] In relation to Plack: Should we add a PERL rule that prohibits defining lexical variables (my $var) in MODULES at the outermost block (file level), and also prohibits directly accessing file level lexicals in subroutines of SCRIPTS. (cait, 15:11:04) * Martin Renvoize, PTFS Europe (ashimema, 15:11:50) * Barton Chittenden, bws, Louisville, KY, USA (barton, 15:15:56) * ACTION: pianohacker will draw up a draft of a coding guideline regarding global variables in modules/CGI scripts, see https://perl.apache.org/docs/general/perl_reference/perl_reference.html#my____Scoped_Variable_in_Nested_Subroutines for context (pianohacker, 15:22:12) * Zeno Tajoli, CINECA, Italy (tajoli, 15:25:05) * AGREED: PERL18 and PERL19 to be removed, as the deprecated modules are no longer part of the codebase (C4::Dates and SQLHelper) (cait, 15:30:08) * AGREED: PERL16 - Modules in the Koha namespace should be object oriented when possible, using Koha::Object(s) as a preferred base. PERL16.1 - If an Koha::Object already exists, use it instead of other methods of table CRUD. (cait, 15:53:24) * AGREED: Grandfather clause: XXX - Patches submitted before the introduction of a new rule may pass QA even if they do not meet the current coding guideline requirements after consulting with the QA team members. ? (cait, 15:59:12) * AGREED: Grandfather clause: XXX - Patches submitted before the introduction of a new rule may pass QA even if they do not meet the current coding guideline requirements of the discretion of the QA team member. (cait, 16:07:50) * AGREED: PERLXX: CGI scripts that handle CRUD operatiosn ( Create, Rad, Update, Delete ) should all be handled in the same script when possible. (cait, 16:15:47) * PERLXX shoudl link to admin/cities.pl for a good example (cait, 16:16:06) * ACTION: pianohacker to suggest a possible guideline for handling disagreements (cait, 16:24:37) * AGREED: PERL XXX: New modules should be added to the Koha namespace as C4 is deprecated. (cait, 16:28:19) * AGREED: to remove PERL11: No CVS - Development has moved from CVS to git. Therefore the use of CVS keywords $Id$ and $Revision$ should be discontinued. (cait, 16:35:50) * AGREED: to remove HTML5: Deprecation of the 'prog' and 'CCSR' OPAC themes.' Templats are long gone (cait, 16:36:02) * ACTION: cait to apply agreed to changes on the wiki (cait, 16:38:08) Meeting ended at 20:47:20 UTC. Action items, by person ----------------------- * cait * cait to apply agreed to changes on the wiki * pianohacker * pianohacker will draw up a draft of a coding guideline regarding global variables in modules/CGI scripts, see https://perl.apache.org/docs/general/perl_reference/perl_reference.html#my____Scoped_Variable_in_Nested_Subroutines for context * pianohacker to suggest a possible guideline for handling disagreements People present (lines said) --------------------------- * cait (209) * khall (79) * pianohacker (72) * Joubu (61) * marcelr (36) * bag (31) * tcohen (21) * cc (20) * barton (18) * huginn` (7) * wahanui (7) * jajm (6) * tajoli (6) * kidclamp (5) * gmcharlt (5) * talljoy (5) * ashimema (4) * oleonard (4) * indradg (3) * huginn (3) * matts (1) * oleonard_ (1) * NateC (1) * drojf2 (1) * gaetan_B (1) * andreashm (1) Generated by `MeetBot`_ 0.1.4