14:03:13 #startmeeting Development IRC meeting 13 September 2017 14:03:13 Meeting started Wed Sep 13 14:03:13 2017 UTC. The chair is kidclamp. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:03:13 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:03:13 The meeting name has been set to 'development_irc_meeting_13_september_2017' 14:03:27 #topic Introductions 14:03:28 #info wahanui, a bot that has become sentient 14:03:36 #info Nick Clemens, ByWater Solutions 14:03:41 #info Jonathan Druart 14:03:58 #link https://wiki.koha-community.org/wiki/Development_IRC_meeting_13_September_2017 #empty 14:04:27 #info Tomas Cohen Arazi, Theke Solutions 14:04:44 #info Jesse Maseto, BWS 14:05:07 #info Marc VĂ©ron Switzerland 14:05:10 #info Michael Cabus, BWS 14:05:36 #info Barton Chittenden, BWS 14:06:07 ping fridolin cait 14:06:52 #info Owen Leonard, Athens County Public Library, Ohio 14:07:01 #topic Announcements 14:07:17 none from me 14:07:30 * oleonard seems to only attend meetings which he is inadvertently present for 14:07:42 pianohacker here? 14:08:02 none from me 14:08:05 #info Danielle Elder, BWS 14:08:12 Can I? 14:08:19 go for it tcohen 14:08:46 Jonathan and I are almost finished with dockerizing the jenkins tests 14:08:54 I expected to have it earlier 14:09:19 we might be capable of doing so for the stable branches 14:09:23 with a small effort 14:09:45 I repeat the request for people familiar with Docker to aid us 14:09:47 :-D 14:10:17 done 14:10:28 * oleonard once wore a pair of Dockers khakis, FWIW. 14:10:31 #info Dockerizing jenkins is almost done, anyone with Docker experienced is welcome to help 14:10:47 #topic Update from the Release manager (17.11) 14:10:58 #info Fridolin Somers, Franche, Biblibre 14:11:03 QA sprint was good, and NQA queue is growing again, so I guess we will organise another one soon. 14:11:04 RMint 17.05 14:11:31 I am going to announce feature freeze very early, as I do not want to see people active only the last month before the release. 14:11:39 So nothing marked as (real) enh will be pushed after October ~25th 14:11:48 Joubu++ 14:11:55 Joubu++ 14:11:56 If you want things to get pushed, it's now (and last 4 months...) 14:12:00 #info QA sprint went well, will organise another as queue grows 14:12:11 I am waiting for the docker on jenkins to be ready to push Rest API related patches. 14:12:24 #info early feature freeze, so get enhancements in before 10/25 14:12:44 on the dev side, I am going to work on bug 19297, there are very weird things in this area 14:12:44 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19297 enhancement, P5 - low, ---, jonathan.druart, ASSIGNED , Standardize "can place hold" calculations 14:12:45 #info REST patches awaiting docker/Jenkins completion 14:13:11 and the move to OOP makes things more easy and understandable. I hope I will be able to clean that area 14:13:20 patches are coming soon 14:13:36 but it's not a RM related job, you can move on :) 14:13:55 #info Joubu working on bug 19297 too 14:14:06 #topic Updates from the Release Maintainers 14:14:11 fridolin 14:14:12 fridolin is busy at the moment, I asked him to backport the bug fix 14:14:52 kidclamp: yep thanks 14:14:57 Ha! And security releases last month, next ones are going to include security stuffs as well 14:15:04 indeed 14:15:24 next release will be 17.05.04 14:15:49 not a lot of patches because of my vacansions 14:16:03 but i check on bugs major and more 14:16:18 #info security releases last month and upcoming 14:16:27 and i've pushed patches about translation 14:16:30 nice work btw 14:16:45 #info frido was away but now catchign up and pushing 14:17:14 I'm cool 14:17:15 cait ? 14:17:15 cait is probably the best friend you could ever have. 14:17:29 cait said shemight catch end of metting 14:17:38 so we can move on i thnk 14:17:57 #topic Updates from the QA team 14:18:37 I will just add I was out end of July and most of August getting back into routine now 14:18:54 kidclamp: we missed you :-D 14:19:13 thanks 14:19:14 kidclamp vacations like a European 14:19:23 marcel said he would be out for three weeks 14:19:30 so, next two 14:20:36 anything Joubu tcohen khall atheia ashimema? 14:20:46 Joubu: when do you want to do the QA sprint? 14:20:53 for the next topic, yes 14:20:53 huh.. wa 14:21:00 oops 14:21:03 bag jajm 14:21:10 tcohen: I am going to do the same as last one, send a poll and see your availabilities 14:21:21 alright 14:21:24 #info Joubu will send a poll for next QA sprint 14:21:33 maybe next friday :-P 14:21:35 #info remember to set yourself as qa contact when looking at a bug 14:21:39 ^is for me :-) 14:22:40 #topic General development discussion (trends, ideas, ...) 14:22:48 Commit messages - I sent a reminder about commit messages. You should all read it 14:23:03 commit messages + bug titles: they cannot be the same, it's not possible 14:23:13 one is the problem, one is the fix 14:23:16 unless it's a new ft 14:23:21 anyway, read it. 14:23:37 Then I'd like to see if we could agree on a way to standardize the commit messages 14:23:51 "Bug 12345: my commit message" 14:23:51 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12345 enhancement, P5 - low, ---, oleonard, NEW , Can't Clear Reading History for Anonymous patron 14:23:52 #link http://lists.koha-community.org/pipermail/koha-devel/2017-August/043991.html Commit messages and bug titles guidelines 14:24:01 +1 14:24:06 +1 14:24:07 +1 14:24:10 +1 14:24:15 and "Bug 12345: (qa-follow-up) a QA note about what my fix does" 14:24:33 I personnaluy copi from Bugzilla whitch is : "Bug xxx - toto" 14:24:35 and "Bug 12345: (follow-up) same commit msg as before" # i.e. can be squashed 14:24:38 https://wiki.koha-community.org/wiki/Commit_messages 14:24:46 the git log is aweful, and commit messages are often wrong 14:24:49 yeah, can we change BZ display? 14:24:53 you can blame me for that too ;) 14:25:27 everybody prefers ':' than '-'? 14:25:29 then you can write a git hook to replace it if you like 14:25:53 * oleonard doesn't care as long as we are consistent. 14:26:01 But I do like being able to copy from the Bugzilla heading 14:26:10 so should this go into coding guidelines? so we have a standardized list of how to? 14:26:20 same has owen 14:26:28 * Joubu prefers ": ", there is one more char to describe the patch 14:27:01 you are not suppose to copy bugzilla headings :) 14:27:04 indeed ;) 14:27:14 pick the numbers from the url, and you are done 14:28:45 Even though pianohacker doesn't appear to be awake could we talk about the ES6 usage thread from the mailing list? 14:28:52 http://lists.koha-community.org/pipermail/koha-devel/2017-August/043910.html 14:29:44 are we done on commit messages? 14:29:58 ok, so how do we process? 14:29:58 I send an email to koha-devel, either you do not agree and suggest a counter proposition, or it's validated and added to the guidelines? 14:29:58 I update the commit messages before push (do not resend to bz) for a month, then ask authors to follow guidelines (fqa) 14:30:15 ok, so how do we process? 14:30:23 I send an email to koha-devel, either you do not agree and suggest a counter proposition, or it's validated and added to the guidelines? 14:30:30 I update the commit messages before push (do not resend to bz) for a month, then ask authors to follow guidelines (fqa) 14:30:35 joubu is in a loop 14:30:47 sorry, has been disconnected 14:30:56 did not know it was sent 14:31:17 hehe 14:31:28 I think write up as guideline and then a vote to accept next meeting 14:31:54 +1 14:32:10 k 14:32:39 something else? ES6? 14:32:46 #info Joubu will draft a coding guideline for commit messages to be voted on next meeting 14:32:51 #action Joubu will draft a coding guideline for commit messages to be voted on next meeting 14:32:57 oleonard? 14:32:58 oleonard is still here, if you just wish hard enough. or Koha's master UI designer 14:33:38 #link http://lists.koha-community.org/pipermail/koha-devel/2017-August/043910.html 14:34:03 I think the discussion is boiling down to "When and how do we compile assets" 14:35:31 My thought is: Could we incorporate this build process into the release process, rather than the installation process? 14:36:10 it is the same discussion we could have about our less approach 14:36:25 Solving this issue will lay the groundwork for a lot of positive improvements to our front-end asset handling 14:36:36 (which is basically what tcohen just said) 14:36:48 I think we should have it as a release management process for now 14:36:53 to ease adoption 14:37:03 yes, just pick one and try 14:37:17 if it does not work, we test the other option 14:37:39 pick the one that hurts the less on the distribution/deployment side for the general public 14:37:51 Adding it to the release management process would slightly complicate the process for developers, but that's our job and we can handle it. 14:38:30 +1 14:38:31 so we just need a wiki page 14:39:19 #action pianohacker should write a wiki page for compiling assets in the release process 14:39:33 that's what happens when you sleep in 14:39:49 hehe 14:40:04 No objections to that plan? 14:40:37 * kidclamp looks for dissenting views, sees none 14:40:43 silence means everybody agrees 14:40:58 +1 14:40:58 Thanks everyone :) 14:41:16 #info release process is suggested as proper time to compile assets, put onus on developers 14:41:29 @later tell pianohacker check the irc meeting minutes 14:41:29 kidclamp: The operation succeeded. 14:41:49 #topic Review of coding guidelines 14:41:56 Anything here? 14:42:10 we should implement some workflow for UI development on kohadevbox, including watcher and some live-reload lib 14:42:16 sorry, OT 14:42:29 tcohen++ 14:42:36 +1 14:43:06 oleonard: if you have any suggestions, file an issue on digibib/kohadevbox 14:43:43 no worries tcohen 14:43:57 ok? 14:44:48 anyone have anything else before we move to next meeting 14:45:23 QAers, please QA 14:45:42 #info QAers, please QA all the things 14:45:52 #topic Set time of next meeting 14:46:07 * oleonard thinks this pot of coffee could have used some QA 14:46:33 prove t/bean_dependent/Brew.t 14:46:50 kidclamp: lol 14:47:19 September 27th, 21 UTC? 14:47:37 +1 14:48:12 +1 14:48:19 +1 14:49:08 #info Next meeting: September 27th, 21 UTC 14:49:21 last chance! 14:49:49 #endmeeting