19:00:43 <kidclamp> #startmeeting Development IRC meeting 29 May 2019
19:00:43 <huginn`> Meeting started Wed May 29 19:00:43 2019 UTC.  The chair is kidclamp. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:43 <huginn`> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
19:00:43 <huginn`> The meeting name has been set to 'development_irc_meeting_29_may_2019'
19:00:54 <kidclamp> #topic Introductions
19:01:04 <kidclamp> #info NIck Clemens, ByWaterSolutions
19:01:04 <cait> #info Katrin Fischer, BSZ, Germany
19:01:18 <bag> #info Brendan Gallagher, ByWater
19:01:18 <greenjimll> |#info Jon Knight, Loughborough Uni, UK
19:01:18 <kidclamp> #link https://wiki.koha-community.org/wiki/Development_IRC_meeting_29_May_2019 meeting agenda
19:02:09 <cait> hm
19:02:18 <cait> we should have the vote for naming the rleases after muppets today
19:02:30 <davidnind> #info David Nind, Wellington, New Zealand
19:03:19 <kidclamp> heh, taking advatange of the attendence cait :-)
19:03:27 <davidnind> https://en.wikipedia.org/wiki/List_of_Muppets
19:03:31 <kidclamp> well, 5 of us, this can be short :-)
19:03:35 <kidclamp> #topci Announcements
19:03:36 <bag> +1
19:03:41 <cait> kidclamp: typo :)
19:03:45 <kidclamp> #topic Announcements
19:03:56 <kidclamp> I announce that I just got home today, so expect many typos
19:04:07 <bag> welcome home
19:04:14 <cait> welcome back
19:04:16 <kidclamp> the jetlag is real
19:04:18 <kidclamp> thanks!
19:04:51 <cait> no announcements from me
19:04:53 <kidclamp> anyone else have announcements?
19:05:00 <bag> nada
19:05:03 <greenjimll> Nope
19:05:29 <cait> davidnind? :)
19:05:54 <kidclamp> #topic Update from the Release manager
19:06:04 <davidnind> Swedish Koha User Group meeting in October https://koha.se/en/koha-i-sverige/save-the-date-anvandarmote-svenska-kohanatverket-15-17-oktober-2019/
19:06:06 <bag> RM has jetlag
19:06:22 <kidclamp> I am prepping for release, thank you to many of you for hands on the release notes
19:06:26 <kidclamp> davidnind++
19:06:28 <kidclamp> cait++
19:06:33 <kidclamp> ashimema++
19:06:35 <kidclamp> koha++
19:06:39 <kidclamp> joubu++
19:06:53 <bag> kidclamp++
19:07:04 <kidclamp> will do final pushing and reviews tonight and shepherd things out tomorrow
19:07:04 <cait> kidclamp: there are quite a few notes for you to 'remove'
19:07:08 <kidclamp> :-)
19:07:20 <cait> i can go through them tomorrow and standardize to RMNOTE like martin started if you want
19:07:30 <kidclamp> yes, joubu has a helper for generating notes too
19:07:41 <kidclamp> I think next release we can find a way to automate removing unwanted notes
19:07:42 <cait> hm?
19:07:56 <kidclamp> anywho, just trying to get things done :-)
19:08:03 <cait> ... and please people stop pushing follow-ups to already released bugs
19:08:12 <kidclamp> :-)
19:08:28 <kidclamp> #info release coming along, thanks to all for hands on releasenotes
19:08:37 <cait> #info Don't push follow-ups with bug numbers that have already been released!
19:08:44 <kidclamp> heh
19:08:56 <kidclamp> #topic Updates from the Release Maintainers
19:09:00 <cait> um
19:09:02 <cait> i had a concern
19:09:08 <kidclamp> oh, osrry
19:09:08 <cait> little too fast
19:09:10 <cait> Mana
19:09:14 <kidclamp> #chari cait
19:09:15 <cait> i can do that in qa
19:09:19 <kidclamp> #chair cait
19:09:19 <huginn`> Current chairs: cait kidclamp
19:09:35 <cait> let's to maints and i say my thing in QA
19:09:48 <kidclamp> lukeG: around?
19:10:48 <kidclamp> #maints will work on their releases too I am sure :-)
19:10:58 <cait> #info rmaints working on their releases
19:11:40 <kidclamp> moving on?
19:11:42 <cait> yep
19:12:00 <kidclamp> #topic Updates from the QA team
19:12:25 <cait> I am concerned about the bugs left open for Mana
19:12:46 <cait> we will be advertising this as a new feature in the release notes and people were also hyped up at Kohacon
19:12:46 <cait> but
19:12:50 <cait> bug 22915
19:12:50 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 blocker, P1 - high, 19.05, koha-bugs, NEW , Cannot subscribe to Mana-KB
19:12:55 <cait> bug 22210
19:12:55 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 major, P5 - low, ---, alex.arnaud, Signed Off , Allow organisations to sign up to Mana KB (don't only ask for firstname lastname)
19:13:13 <cait> i believe alex_a is still on vacation as paul_p said last week
19:13:20 <cait> I have no idea how we can fix this
19:13:41 <cait> Mana has been pushed early, but the bugs have not been taken care of :(
19:14:24 <kidclamp> can other recreate registration problems?
19:14:49 <cait> it certainly needs more testing, but i don't know how
19:15:29 <cait> it looks like there are several mana domains
19:15:35 <tcohen> #info Tomas Cohen Arazi, Theke Solutions
19:15:37 <cait> production, test and also ui.mana-kb
19:15:40 <cait> i am confused
19:15:58 <cait> also: http://mana.koha-community.org/
19:16:03 <greenjimll> Is it something that could be billed as a "first cut preview release"?
19:16:11 <bag> @seen paul_p
19:16:11 <huginn`> bag: paul_p was last seen in #koha 6 weeks, 5 days, 9 hours, 20 minutes, and 13 seconds ago: <paul_p> hi cait
19:16:15 <cait> bug 22913
19:16:15 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 minor, P5 - low, ---, koha-bugs, NEW , https://mana-kb.koha-community.org/ should not return a 404 error
19:16:24 <cait> sorry, wrong url above
19:16:52 <cait> greenjimll: i am more leaning to deactivating it
19:17:01 <cait> and releasing it with .01 at this point
19:17:18 <cait> unless we can fix the sign up
19:17:38 <cait> but it leaves the argument about what data we shoudl ask for at sign-up - not sure if it matters if we change that later
19:17:45 <cait> right now it's surname lastname
19:17:48 <kidclamp> by deactiviating you mean disabling the advertising of the feature?
19:18:07 <cait> shoudl be change to just be name
19:18:18 <cait> i dunno
19:18:23 <cait> what do people think?
19:18:32 <cait> I can try to test tomorrow... but i already got stuck
19:18:35 <greenjimll> O
19:18:37 <greenjimll> I
19:18:40 <greenjimll> Oops
19:18:49 <kidclamp> I think if we can verify if registration works or not we can decide - if one can register I think beta is ok and we can fix the name part later
19:18:58 <cait> ok
19:19:04 <greenjimll> I'd say that the last name/first name is less of an issue than the failures to sign up/404s
19:19:06 <kidclamp> if we really can't register at all I would ocnsider disabling the message
19:19:21 <cait> greenjimll: agreed, if we can change it later easily
19:19:30 <cait> shoudl be possible i guess
19:19:46 <cait> i just really wished we coudl release this more polished
19:19:46 <davidnind> if something is not ready, what do we normally do?
19:19:55 <cait> davidnind: not push it ;)
19:20:03 <tcohen> disable by default, and maybe mark it EXPERIMENTAL on the sysprefs
19:20:09 <tcohen> (the on/off switch description)
19:20:55 <cait> at least generally, tcohen's suggestion is good too
19:20:59 <greenjimll> I assume it did work at some point to get signed off/QAed/pushed?
19:21:07 <cait> it's pretty 'in the face' right now
19:21:11 <kidclamp> yes, the feature was tested and was successful
19:21:13 <cait> asking you to decide to turn it on/off
19:21:59 <greenjimll> So its a problem in the service its talking to rather than the Koha codebase?
19:22:12 <cait> i think of the sign-off issue that might be part of the issuse
19:22:37 <cait> that we cannot fix if something has to be fixed on the mana server
19:23:17 <greenjimll> But similarly if its effectively a "third party" service (the Mana server in this case) that's the issue, that could happen just as easily after release as before.
19:24:15 <kidclamp> I think mana is very new, we expect some growing pains, but I would still ratehr have it than not
19:24:38 <kidclamp> I am going to test registration today and would ask that others do as well
19:24:41 <cait> it woudl not look to pull out now
19:24:45 <cait> not look good
19:24:50 <kidclamp> bug 17047
19:24:50 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 new feature, P5 - low, ---, alex.arnaud, RESOLVED FIXED, Mana Knowledge Base : Data sharing
19:24:50 <cait> so fixing is much preferred
19:25:09 <kidclamp> instructions are there on setup
19:25:23 <cait> according to the sign-up bug the registration on test might not work as the changes have been applied there
19:25:31 <cait> or should only work with the patch applied
19:26:16 <cait> just noting for people testing
19:26:27 <cait> so probably need to test master with production
19:27:24 <cait> @action all hands on deck testing Mana registration please
19:27:24 <huginn`> cait: I suck
19:27:44 <cait> #info see bugs 22915 and bug  22210
19:27:44 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 major, P5 - low, ---, alex.arnaud, Signed Off , Allow organisations to sign up to Mana KB (don't only ask for firstname lastname)
19:27:57 <cait> #action all hands on deck testing Mana registration please
19:28:09 <cait> kidclamp: otherwise let me know if you need something - i will be around tomorrow
19:28:15 <kidclamp> will do
19:28:37 <bag> I’ll ping you kidclamp if I have any problems with it
19:28:55 <cait> maybe ping for success too :)
19:28:55 <kidclamp> thanks bag!
19:29:05 <cait> i'd be relieved
19:29:08 <bag> ok cait :)
19:29:14 <kidclamp> moving on, fingers crossed, hopefully :-)
19:29:43 <cait> :)
19:29:59 <kidclamp> anything else for QA cait?
19:30:18 <tcohen> I will be available for QA
19:30:22 <tcohen> let me know
19:30:35 <tcohen> or bugfixes, cait
19:30:38 <cait> tcohen: anything sip2 and rest api in the queue please ;)
19:31:32 <tcohen> (y)
19:31:51 <cait> that doesn't trnaslate into a picture for me
19:32:09 <kidclamp> :+1
19:32:29 <bag> +1
19:32:34 <tcohen> thumbs up
19:32:41 <kidclamp> #topic General development discussion (trends, ideas, ...)
19:32:43 <kidclamp> Anyone?
19:32:53 <cait> ah
19:32:55 <cait> i got one
19:33:06 <cait> How to add indexes for authorities
19:33:08 <cait> i am trying and i failed
19:33:14 <cait> ended up with bug 23000
19:33:14 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23000 normal, P5 - low, ---, koha-bugs, NEW , Running xsltproc for authority index definitions adds unwanted changes
19:33:17 <cait> and bug 23001
19:33:17 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23001 major, P5 - low, ---, koha-bugs, NEW , When the whole authority record is searched, search always returns all records
19:33:26 <cait> but still didn't get it working... and the second is kinda bad
19:33:53 <cait> if it finds something = the results are right, i just checked
19:33:59 <cait> but if it finds noting, it just gives you 'all'
19:34:58 <cait> there has been someone desperate about this on the mailing list, that's why I tried
19:35:32 <cait> getting some help there would be nice :)
19:35:38 <kidclamp> yeah, those are bad
19:36:06 <tcohen> we should really have 21073 on 19.05 already
19:36:08 <cait> hm i can't replicatet the second right now... same installation as yesterday
19:36:14 <cait> someone else taking a look even more appreciated
19:36:24 <cait> bug 21073
19:36:24 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 enhancement, P5 - low, 19.05, kyle, Signed Off , Improve plugin performance
19:37:31 <cait> quiet
19:37:38 <cait> i am not sure if i can test this
19:37:54 <tcohen> the main problem is it was tested by two Theke members...
19:38:33 <cait> i can run the basic test
19:38:38 <cait> but can't do performance testing
19:39:12 <cait> so i can offer a sign-off maybe?
19:39:56 <cait> @random
19:39:56 <huginn`> cait: Error: The command "random" is available in the Dict, Factoids, and Quote plugins.  Please specify the plugin whose command you wish to call by using its name as a command before "random".
19:40:06 <cait> so quiet... had to check if I am still here :)
19:40:08 <tcohen> cait: no need to test performance actually
19:41:08 <greenjimll> Does the performance improvement appear on a small test/dev instance, or is it only noticeable on large systems?
19:41:31 <davidnind> Is the title wrong then? Looks like general improvement to plugins, rather than performance (not that I know anything about plugins).
19:42:03 <davidnind> After a five second scan of the bug :)
19:42:47 <tcohen> right now, any place that has hooks for plugins
19:42:55 <greenjimll> cait: we're all reading the bugzilla report which is why we're quiet.
19:42:56 <tcohen> triggers a search for existing plugins
19:43:01 <tcohen> on the filesystem
19:43:10 <tcohen> looking for those that implement X methods
19:43:27 <tcohen> this bug makes plugins tell Koha what methods they implement
19:43:32 <tcohen> and they are stored on the DB
19:43:39 <tcohen> so a simple SQL query on MySQL
19:43:51 <tcohen> instead of traversing the filesystem and loading the plugins, just in case
19:44:06 <cait> what will happen if a plugin doesn't do it?
19:44:11 <greenjimll> So something that will be more noticeable performance improvement on a large system?
19:44:16 <cait> (backwards compatibility)
19:44:27 <tcohen> this bug implements it so the plugin does nothing
19:44:38 <tcohen> there's some introspection on what method the plugin has
19:44:43 <tcohen> and they get populated on the DB
19:44:49 <tcohen> next step is to streamline this
19:44:51 <cait> #chair davidnind
19:44:51 <huginn`> Current chairs: cait davidnind kidclamp
19:44:54 <kidclamp> I have to run all, but I wil be back later and early tomorrow to finish up
19:45:07 <kidclamp> #chair bag
19:45:08 <huginn`> Current chairs: bag cait davidnind kidclamp
19:45:12 <cait> so it will work with current plugins still
19:45:14 <tcohen> and have plugins 'tell' what they are capable of
19:45:18 <tcohen> yes
19:45:19 <cait> but be better if they do it
19:45:21 <cait> cool
19:45:31 <tcohen> when we make that transition after this bug
19:45:36 <tcohen> we will add an alert on about.pl
19:45:47 <tcohen> to tell users to ask plugin authors to move to the 'new style'
19:45:48 <bag> cait I just had no problems with registering for mana
19:45:55 <tcohen> that's at least the plan
19:46:00 <cait> bag: really glad to hear
19:46:06 <cait> can you comment on the bug please?
19:46:20 <cait> tcohen: sounds good
19:46:41 <bag> bug 17047 ?
19:46:41 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 new feature, P5 - low, ---, alex.arnaud, RESOLVED FIXED, Mana Knowledge Base : Data sharing
19:46:52 <cait> bug 22915
19:46:53 <huginn`> 04Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22915 blocker, P1 - high, 19.05, koha-bugs, NEW , Cannot subscribe to Mana-KB
19:46:53 <bag> or the other patches cait
19:46:57 <bag> thanks
19:47:14 <cait> ok
19:47:15 <cait> moving on?
19:47:38 <cait> #topic Review of coding guidelines
19:48:11 <davidnind> tcohen++ Improvements to koha-testing-docker: can now run if you don't have an internet connection; command line aliases documentation makes it easier to use, for example ku = docker-compose -p koha up; fix git so alias
19:48:25 <davidnind> Link https://gitlab.com/koha-community/koha-testing-docker#aliases
19:48:36 <cait> #info  Improvements to koha-testing-docker: can now run if you don't have an internet connection; command line aliases documentation makes it easier to use, for example ku = docker-compose -p koha up; fix git so alias
19:48:43 <cait> tcohen++
19:49:13 <cait> we have nothing on the agenda for this topic
19:49:19 <cait> will move on
19:49:27 <cait> #topic Set time of next meeting
19:49:32 <cait> can someone help me out here?
19:50:12 <greenjimll> Will the next one be four weeks from today?
19:50:15 <cait> 2 weeks?
19:50:34 <greenjimll> 14:00 UTC on 12th June 2019?
19:50:41 <cait> sounds good
19:51:03 <cait> #info Next meeting: 12 June 2019, 14 UTC
19:51:08 <cait> hope i got it right
19:51:19 <cait> thx all for attending (and bearing with grumpy me)
19:51:23 <davidnind> Looks good to me!
19:51:26 <cait> #endmeeting