14:01:36 #startmeeting Development IRC meeting 12 October 2022 14:01:36 Meeting started Wed Oct 12 14:01:36 2022 UTC. The chair is tuxayo. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:01:36 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:01:36 The meeting name has been set to 'development_irc_meeting_12_october_2022' 14:01:55 #link https://wiki.koha-community.org/wiki/Development_IRC_meeting_12_October_2022 Today's agenda 14:02:00 #topic Introductions 14:02:19 not sure it'll help or not oleonard.. but we updated all our ill backends today for 21.11 compatability: https://github.com/PTFS-Europe/koha-ill-freeform 14:02:23 #info Victor Grousset, Tuxayo Empire 14:02:24 ooop 14:02:32 #info Martin Renvoize, PTFS Europe 14:02:34 * tuxayo is starting to get paid for Koha work! 14:02:53 #info Thomas Dukleth, Agogme, New York City 14:03:08 * ashimema is currently going through CV's.. PTFS-E are hiring. 14:03:32 Great to hear that your job offer got candidates :) 14:04:15 rmaints? 14:04:15 rmaints are lukeg, liliputech and tuxayo 14:04:18 qa_team? 14:04:18 qa_team is cait, marcelr, khall, kidclamp, kohaputti, lukeg, aleisha, fridolin, ashimema, tuxayo, nugged, petrova, Joubu and dcook 14:04:59 #info Andrew Nugged, National Library of Finland, HELSINKI 14:05:14 #topic Announcements 14:05:25 Anything to announce that doesn't fit better the other topics? 14:05:51 #info, Nick Clemens, ByWater Solutions 14:06:12 #info Kyle M Hall, ByWater Solutions 14:06:23 #info, Lucas Gass, ByWater Solutions 14:06:42 nugged: maybe you can quickly sum up the stuff you said in the other meeting slot two week again for the people that weren't there at this time slot. 14:07:56 Or i can just post the link to the logs were you started informing us about next KohaCan last time: http://irc.koha-community.org/koha/2022-09-28#i_2452713 14:08:05 *KohaCon 14:08:29 Moving on? 14:08:39 yes 14:08:46 so - we confirmed the dates, 14:08:54 excellent 14:08:54 darn tootin' it is. 14:08:57 #info Marcel de Rooy, Rijksmuseum 14:09:09 and last Friday I personally inspected booked "rooms" in University building 14:09:31 Dates: 14:09:31 (CONFIRMED) 14-16 August 2023 (14-18 with workshops and extras). 14:09:31 recommended trip: Sat 12 Aug .. Sun 20 Aug. 14:09:34 as said here: 14:09:34 https://bit.ly/PerlKohaCon_welcome 14:09:42 nugged++ 14:09:52 some FAQ section updated because of Perl Community requests 14:10:29 but I still working with Perl Community part. Allowed to their Slack now not as Guest but member & will have announce talk maybe (I am trying and doing my best) no later next week 14:10:35 to start those movements as well 14:11:26 then I'll start coming to bigger players to ask for participation (PTFS-E, BibBlibre, of course ByWater, so on) and our Core team members, getting some feedback and coordination 14:11:57 I _hope_ through october having full agreements/OKs & form up the final plan and start work on ogra- steps on December. 14:12:38 * ashimema has added it to the Koha Calendar now 14:12:40 If anyone of you already know some gathering (Perl or Koha or Library-IT related where it's good for me to come and announce the Conference) – tell me please, I will be glad (Zoom/etc) 14:12:59 I mean - I will come with talk on meetings you will have so if someone already can propose some to me - PM me. 14:13:23 then - let's say - let's put in meeting schedule my report once more in here in IRC on our next IRC meeting. 14:13:27 :q 14:13:32 «Should Perl people be concerned about "Koha" everywhere? NO. You won't get bored if you don't want to get around Koha» 14:13:32 Ha ha ha. Great, we don't want to scare people with book stuff :P They might end up sucked into Koha anyway. He he he. 14:14:23 Final thing: yes, I want to be as much as possible visitors from Perl world, as well from Koha world, even if those are non-crossed entities (we will work on that further :) ) 14:14:34 excellent 14:14:34 darn tootin' it is. 14:14:47 Great information page! 14:14:51 (final thing cont): so I am asking all to prep to VISIT Helsinki! :) Beer & fun from me guaranteed! :) 14:14:54 that's it for now. 14:15:12 PM me for any more you want me to do on this or ideas. 14:15:20 Thanks the update! 14:15:30 ashimema: and yes, we should put "PTFS-E" HR booth there in lobby as well as others. 14:15:34 «heal post-covid anthropophobia and huggophobia.» 14:15:34 🤗++ 14:16:17 Moving on if nothing to add. 14:16:29 Yes, I want us to make something really impressive and unusual. Will lay all my extra time on that. 14:16:39 yes. Moving further. 14:16:39 ++ 14:16:53 #topic Update from the Release manager (22.11) 14:17:13 Is El tcohen around? 14:17:47 he was a moment ago 14:18:15 He has been very busy. 14:18:15 one sec, we distracted him 14:18:19 ^^ 14:18:21 #info Tomas Cohen Arazi 14:18:27 hi all <.< 14:18:30 tcohen: 🎙️ 14:18:40 hi ^o^ 14:18:51 re-reading, sorry 14:19:10 Hi all, I'm back from a short vacation 14:20:04 I've been pushing a lot, and I'm about to push the 'staff revamp' 14:20:12 so we have time to fix things 14:20:47 > I'm about to push the 'staff revamp' 14:20:47 wooooow 🤩🤩🤩🤩 14:20:51 I want bug 31378 in, and more eyes are needed tehre 14:20:51 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 new feature, P5 - low, ---, agustinmoyano, Needs Signoff , Add a generic OAuth2/OIDC client implementation 14:20:52 team++ 14:22:03 bug 26635 should be in too, I will focus on that the rest of the week, as it is a blocker for serious API usage 14:22:03 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 enhancement, P5 - low, ---, agustinmoyano, In Discussion , Expand authorised values in REST API call 14:22:47 tcohen++ 14:22:53 #action khall offered to restore progress bars if peple file bugs, depending on bug 31666 for that 14:22:53 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 enhancement, P5 - low, ---, kyle, Pushed to master , Add job progress bar to stage-marc-import.pl 14:23:00 > and more eyes are needed tehre 14:23:00 - I'll get back Slava to it to check too. 14:23:01 khall++ 14:23:33 khall++ 14:24:04 About ERM: I'm in talks with PTFS-e and ByWater about that. 14:24:26 it has a chance as an opt-in experimental feature imho 14:24:28 Talks about what? ^^" 14:24:38 about the progress and the state it is at 14:24:45 Great! 14:24:51 i.e. if it is gonna be pushable soon 14:24:56 Ah yes! 14:25:16 khall++ # verbose console output is the best progress bar 14:25:19 jonathan had concerns about some decisions he made on vue integration 14:25:41 * ashimema has been working through the erm code the past few days.. generally happy with what I see.. 14:25:45 which are legit and need to be considered, that's why it is important that PTFS hired someone to pick and continue that work 14:25:47 > an opt-in experimental feature imho 14:25:47 For a new and independent module that seems safe. 14:25:48 few little fixes here and there.. 14:26:14 but.. I'm no vue expert.. that's where we fall down.. none of us are really... so it makes it hard to guide/advise/review 14:26:31 but.. it does all feel pretty solid from my perspective at the moment 14:27:04 ptfs++ 14:27:06 Joubu++ 14:27:09 bywater++ 14:27:26 > I'm no vue expert.. that's where we fall down.. none of us are really 14:27:26 If stuff still makes sense without being an expert, that great. It means it won't be much of an entry barrier. 14:27:54 #action tcohen will send an email with release dates this week, won't differ from usual release dates 14:28:13 this time there are lots of strings for sure, with big refactoring on templates, but it is just a guess 14:28:14 > PTFS hired someone to pick and continue that work 14:28:14 ptfs++ 14:29:07 * tuxayo promises they won't submit massive string changes this time. 14:29:17 (at the last moment) 14:29:19 heh 14:29:26 tuxayo++ # translatability 14:30:08 I still will do something about the breadcrumb strings at some point. 14:30:10 questions for the RM? 14:30:38 tuxayo bug 31670 14:30:38 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31670 enhancement, P5 - low, ---, isobel.graham09, NEW , Fix inconsistency with breadcrumbs in the Patrons module 14:30:48 cait++ # always 14:31:31 That could be done at the same time. Thanks tcohen, I'm noting it my "notes for follow up patches" 14:32:18 breadcrumbs are a mess.. I have no idea if my daughter will get a let up at school though to take a look.. might grab them myself if she doesn't 14:32:41 isobel.graham09 = ashimema's daughter 😜 14:33:05 he he 14:33:06 isobel++ 14:33:15 isobel++ 14:33:39 Send congrats for the nice patches in the last months. 14:33:43 #topic Updates from the Release Maintainers 14:34:00 rmaints? 14:34:00 rmaints are lukeg, liliputech and tuxayo 14:34:01 rmaint? 14:34:01 it has been said that rmaint is definitely a great job to find all kinds of things to fix and clarify in translations, system requirements, CI among others. 14:34:49 I have some catch up before string freeze. And some requested patch to monitor if they come upstream. 14:35:03 *patches 14:35:48 Not much to add otherwise 14:36:02 #topic Updates from the QA team 14:36:03 qa_team? 14:36:03 rumour has it qa_team is cait, marcelr, khall, kidclamp, kohaputti, lukeg, aleisha, fridolin, ashimema, tuxayo, nugged, petrova, Joubu and dcook 14:37:02 Tomorrow, patch testing session with french speakers. Crossing finger. I also have to send a poll for an English speaking session quick. 14:37:17 tuxayo++ 14:37:52 tuxayo++ 14:38:02 doing a great job getting more people onboard tuxayo 14:38:19 qa wise.. I've been a bit low on numbers recently.. just overly busy 14:38:45 marcelr++ and cait++ for picking up the slack so it's not so noticable 14:39:13 tuxayo++ 14:39:34 Any additional hints for channels to reach librarians and system librarians using Koha? (Internationally) I addition to the general list and Koha US list. 14:39:51 QA emails have been taking a difference approach of late.. highlighting nice things that have gone in to help motivate the team.. cait++ 14:40:35 > great job getting more people onboard tuxayo 14:40:35 Still not sure about that, but the potential is definitely here. 14:40:42 there's also now more sections.. old bugs, interesting bugs and bad bugs.. not always present in every email.. but cait is generally doing great things. 14:40:45 Need to keep going 14:40:45 tuxayo Koha user group in NL/BE 14:41:04 cait++ 14:41:30 marcelr: yes, that's what we need! I'll ping you about that later. 14:41:34 there isn't really a single user group in the UK.. there are a few that are just getting up and running.. but not ready for contributing much yet.. 14:41:37 sure 14:42:27 coms channels aren't yet disassociated from ptfs-e.. we're trying to wean them off of us and make them more independant basically. 14:43:07 coms? 14:43:22 communications 14:43:22 communications I guess 14:43:44 I'll keep ccing you ashimema and people from Interleaf to relay messages. 14:43:55 Moving on? 14:44:05 ta 14:44:25 #topic Status of roadmap projects 14:44:30 https://annuel.framapad.org/p/koha_22.11_roadmap 14:46:01 we already talked about most of it on the RM section 14:46:09 thd, tcohen: news about the wiki? 14:46:15 the only thing that I didn't mention is thd's wiki migration 14:46:23 that is blocked because of my own lack of time 14:46:26 thd++ 14:46:50 tcohen and I have been missing times when we are both not too busy or sleepy to connect a customised MediaWiki Canasata to Koha infrastructure . 14:46:58 Everyone needs rest from time to time :) 14:47:16 thd: do you think we can defer the ES stuff for after the migration? 14:47:21 I tried stalking tcohen yesterday but that was not nice. 14:47:24 or you think we shuold do it all together? 14:47:39 ElasticSearch is the easy part. 14:47:49 ok 14:48:09 The whole wiki indexes in 5 min. with 1 GB RAM. 14:48:20 #action tcohen and thd will arrange a date in the next few days 14:48:34 ++ 14:48:41 it all feels sooooo close 14:49:04 It supports good customisations with extensions depending on ElasticSearch which I have customised. 14:49:08 22.11 is uber close too.. yikes.. 14:49:24 * ashimema just made the realisation 14:49:45 feel the freeze 14:49:57 heh 14:49:59 > 22.11 is uber close too 14:49:59 Yes, not enough time to rebase and finish a dev of mine T_T still gonna do it like it's possible so at last the thing is submitted. 14:50:20 there's never enough time :(.. 14:50:33 ElasticSearch does not seem to be a problem when it can be so easily reindexed if with few resources if anything goes wrong. 14:50:57 thd: I only asked because it is just another moving piece adding complexity to the migration 14:51:03 but we will sort it out, for sure 14:51:41 tuxayo: moving on? 14:51:59 #topic Actions from last meeting 14:52:00 I have tamed it with a special script for reindexing and customised Extensions such as AdvancedSearch which depend on ElasticSearch. 14:52:14 «tcohen to schedule/call a "CSRF day" to work on related patches together» 14:52:30 damn :-D 14:53:00 #action tcohen to schedule/call a "CSRF day" to work on related patches together 14:53:39 nugged and team started that, and we got distracted by other urgent stuffs 14:54:12 #action cait /Katrin to update LTS wiki page with current information from last dev meeting 14:54:15 Page not updated. And Katrin sent apologies for not being able to attend today. 14:54:29 «ashimema will file a bug making Koha::Object::public_read_list throw an exception » 14:54:32 tcohen: that means - one more "re-start" day for CSRF? (me: yes, if so). 14:54:42 «Not required, see commit: https://git.koha-community.org/Koha-community/Koha/commit/e0de8364b7c197cd3bd1b70f93766ecc6da11216» 14:54:48 I commented.. we decided it wasn't required 14:54:59 So that's done :) 14:55:04 yup 🙂 14:55:16 «tcohen draft proposal for master→main change and draft of action list » 14:55:50 I haven't had the chance to review Joubu's proposal to shrink the repo, which was part of the plan 14:56:36 one for next cycle now I reckon 14:56:50 I would like to be able to talk to Joubu about that plan 14:56:55 especially with Joubu out for now.. he had dug a lot in that area 14:56:56 before moving forward 14:57:05 agreed 14:57:14 I think we can live one more cycle 14:57:14 what ashimema said 14:57:27 tcohen: I have a side proposal: run on our git server `git gc --prune=now --aggressive` locally it skrink my repo down to 700 MiB 14:57:47 Hopefully that will do the same and will affect the download size 14:58:07 tuxayo: I think we have that cron-ed 14:58:16 I believe so 14:58:28 Joubu's proposal had to do with removing translations from the main repo 14:58:44 which take most of the (historically) used space 14:58:49 Great! Yikes it would be much worse without that cron then. 14:59:11 > which take most of the (historically) used space 14:59:11 ++ 14:59:44 we shoudl probably encourage shallow clones.. but I'd need to remind myself how they work before recommending it. 14:59:44 I've gotta run 14:59:52 When to ask again about the master→main thing? 14:59:59 shallow clones take server's CPU 15:00:06 ah.. ok 15:00:11 tuxayo: right after the release 15:00:16 +1 15:00:22 tcohen: CPU: Not for very long I guess? 15:00:32 we need to measure it, for sure 15:00:50 next topic? 15:00:50 we could encourage people to pull from Gitlab as well 15:01:15 #action tcohen [WAIT after 21.11 release] draft proposal for master→main change and draft of action list 15:01:33 «thd give their two cents on bug 31150 in order to tilt the scale to on side.» 15:01:33 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31150 enhancement, P5 - low, ---, koha-bugs, In Discussion , _on or _date for DB date columns? 15:02:13 «to tilt the scale to on side» <= I failed english XD it was late for my defence 15:02:15 or or xor 15:02:48 Moving one, it was just a minor reminder for thd 15:02:52 «tuxayo ask on the mailing list « are we supporting MySQL? (either 5.7 or 8.0) - CI only tests MySQL 8 on main/master. » » 15:02:58 Done on koha-devel today 15:03:14 * thd retracted his perception of ambiguity unless we rename every use to $date_time 15:03:42 «tuxayo can for volunteers on the mailing list to «Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr - introduced in bug 29239. And document the usage in the wiki. cc Aleisha who had trouble with using flatpickr for the detail of what is missing» » 15:03:42 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 enhancement, P5 - low, ---, koha-bugs, NEW , [OMNIBUS] Replace jQueryUI's timepicker with flatpickr 15:03:56 Done on koha-devel today. 15:04:10 «tuxayo maybe create a ticket for updating the guidelines about flatpickr» 15:04:12 bug 31741 15:04:12 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31741 enhancement, P5 - low, ---, koha-bugs, NEW , Update coding guidelines with the replacement of jQueryUI Datepicker with flatpickr 15:04:28 #topic General development discussion (trends, ideas, ...) 15:04:29 We merely need some coding guidance that a variable with date only should be $date_only 15:04:41 «Bug 31674 - We need a template/guideline around how to consistently form our modals» 15:04:41 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31674 enhancement, P5 - low, ---, martin.renvoize, NEW , We need a template/guideline around how to consistently form our modals 15:05:27 I raised that one.. whilst reviewing the staff client refresh and whilst working on some other code.m 15:05:36 So coding guideline that links to somewhere (to be written) part of the developper handbook with the template? 15:05:49 gotta leave 15:05:53 laters! 15:05:57 We are generally really inconsistent with things... We need a style guide for a lot more things.. 15:05:58 o/ 15:06:03 Including examples . 15:06:11 I can work on some updates to the wiki 15:06:26 I've already suggested I work on it with oleonard assuming that's still ok oleonard 15:06:42 Perfect 15:06:42 Perfect is, like, the enemy... (of what I forgot) 15:07:11 A nice simple modal dialogue for starters.. then another example for a modal that includes a form 15:07:30 Those two I think would cover most use cases.. 15:08:15 I would help if we could link to the right bootstrap docs too.. I constantly find myself confused with which bootstrap versions where using where 15:08:34 Anywho.. that's enough explanation for today I reckon 15:08:59 Then this? : #action oleonard ashimema draft in the developer handbook how to form our modals. With template of a simple case and a case with form inside. 15:09:12 * ashimema wants to pick off components one by one for this.. clear guidelines of breadcrumbs would be good too.. tcohen raised that above 15:09:19 tuxayo: Yes 15:09:24 Great tuxayo 15:09:42 > pick off components one by one for this.. clear guidelines of breadcrumbs would be good 15:09:42 Similar to the needs with flatpickr 15:09:55 But for now modals, then 15:09:59 #action oleonard ashimema draft in the developer handbook how to form our modals. With template of a simple case and a case with form inside. 15:10:07 «git-bz is stuck on Python 2 which went end of life on January 1st 2020.. should we start to consider alternatives? » 15:10:44 This is a bigger discussion.. maybe postpone it . 15:10:45 Python2 It's still in Debian and Ubuntu but for example Arch dropped it. Now it's an unofficial package harder to install. 15:10:51 Ok 15:10:57 +1 postpone 15:11:15 With tcohen gone and me about to go.. it's something we can consider during the next cycle again 15:11:15 #action tuxayo postpone «git-bz is stuck on Python 2 which went end of life on January 1st 2020.. should we start to consider alternatives?» 15:11:29 git-bz related: we use own patched version 15:11:42 to be Py3 compatible 15:11:46 !!! 15:12:11 nugged: please publish it somewhere! :D 15:12:16 Oh nice.. submit that patch to Koha ;) 15:12:18 Python 2 forever :) 15:12:22 That would make me very happy 15:12:23 lol 15:12:52 that what I also wanted to ask because we thought everyone on P2 and only we "kill it everywhere in MacOSes :)" 15:13:25 merge requests welcome ^^ : https://gitlab.com/koha-community/git-bz 15:13:29 good 15:13:39 we'll put our draft for critics tomorrow 15:13:40 > kill it everywhere in MacOSes 15:13:40 ? 15:13:58 We can always advice on using the right branch for your distro if we're worried about breaking back compat 15:14:04 tuxayo: there's no P2 anymore in some environments 15:14:20 yes, that's the problem 15:14:50 ok noted, changes will be proposed. 15:14:50 > because we thought everyone on P2 15:14:50 Every Linux distro ships with a P3 install in parallel of P2 15:15:11 #topic Review of coding guidelines 15:15:14 There are still major enterprise programs at big businesses running Python 2. 15:15:35 nugged: thanks again 15:15:47 « SQL8 of our coding guidelines state that SQL should not be in .pl, but should be in the module in C4 or Koha. This would mean that SQL in the Koha namespace is allowed and there is no mention of DBIC in the coding guidelines right now. » 15:16:11 IIUC, it means only .pm are allowed to have SQL 15:16:25 arch python3 is only available in the aur now.. and is slightly challenging to compile due to failing tests 15:16:39 but anyway.. a python 3 version of git-bz would be awesome 15:16:44 But DBIC schema file should be also allowlisted. 15:16:57 * ashimema has to runn 15:17:03 > arch python3 15:17:03 *arch python2 15:17:09 > a python 3 version of git-bz would be awesome 15:17:09 ++ 15:17:19 I think we'd better wrap it up we keep losing people :D 15:17:37 ++ 15:18:15 #action tuxayo postpone «SQL8 of our coding guidelines state that SQL should not be in .pl, but should be in the module in C4 or Koha. This would mean that SQL in the Koha namespace is allowed and there is no mention of DBIC in the coding guidelines right now.» 15:18:28 #topic Set time of next meeting 15:19:03 Next meeting for the oceania-americas timeslot has been decided last time. I'll go get it 15:19:18 For next meeting this slot: 16th november? 15:19:52 There will be (and already have been) winter time changed in some countries in the mean time. 15:20:09 Is there a need to have more than one between now and the release? 15:20:32 > 16th november? 15:20:32 9th, I jumped a week 15:21:40 > Is there a need to have more than one between now and the release? 15:21:40 Since we split in two time slots, we can do that for releases. 15:22:16 Anyway... 9th is good for me 15:22:39 #info Next meeting: 26 October 2022, 22 UTC 15:22:45 That's for oceania-americas 15:23:33 > Anyway... 9th is good for me 15:23:33 Ok, if needed when can do the 2th of november and the 16th 15:23:50 *we can do 15:24:57 * thd is never awake on the 2th of November. 15:25:29 Still planing the 9th then 15:25:29 > There will be (and already have been) winter time changed in some countries in the mean time. 15:25:29 So what about 15 UTC? It means 16 in france, 10 new york, 7 in LA 15:25:54 +1 15:25:56 12 argentina 15:26:15 +1 15:26:31 I never realized part of the US couldn't attend these meetings now. 15:26:38 Let's settle for that then 15:27:24 #####info Next Americas-Europe slot meeting: 9 November 2022, 15 UTC 15:27:48 #endmeeting