14:02:10 #startmeeting Development IRC meeting 20 July 2022 14:02:10 Meeting started Wed Jul 20 14:02:10 2022 UTC. The chair is tuxayo. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:02:10 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:02:10 The meeting name has been set to 'development_irc_meeting_20_july_2022' 14:02:39 #link https://wiki.koha-community.org/wiki/Development_IRC_meeting_20_July_2022 Today's agenda 14:02:48 #topic Introductions 14:02:56 #info Owen Leonard, Athens County Public Libraries, Ohio, USA 14:03:06 #info Marcel de Rooy, Rijksmuseum 14:03:12 #info Paul Derscheid, LMSCloud GmbH, Munich, Germany 14:03:14 #info Katrin Fischer, BSZ, Germany 14:03:19 #info Nick Clemens, ByWater Solutions 14:03:21 #info Jonathan Druart 14:03:22 #info Thomas Dukleth, Agogme, New York City 14:03:47 #info Victor Grousset, Tuxayo Europe, France 14:03:49 #info Kyle M Hall, ByWater Solutions 14:03:54 #info Tomas Cohen Arazi, Theke Solutions 14:04:39 #topic Announcements 14:04:51 Anything to announce that doesn't fit the other topics? 14:04:59 Yes, announcement, me 14:05:09 🎙️Joubu 14:05:14 (could have fit later but ... well) 14:05:17 #info Martin Renvoize 14:05:17 i heard #info Martin Renvoize was getting back the the Accounts Rewrite bugs 14:05:25 I will be on leave for 2+ months, starting in less than a month. 14:05:30 forget #info Martin Renvoize 14:05:30 cait1: I forgot #info martin renvoize 14:05:40 I have several things in the queue that would be nice to have for 22.11 14:05:50 especially because they are a nightmare to rebase 14:06:05 and I don't think I will pick them back if they haven't been pushed until then... 14:06:12 bug 27272 14:06:12 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 enhancement, P5 - low, ---, stalkernoid, Needs Signoff , Move C4::Items::GetItemsInfo to Koha namespace 14:06:12 you already gave me a list with a few, but can you name them somewhere? 14:06:17 bug 30718 (and friends) 14:06:17 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Use flatpickr's altInput option everywhere 14:06:22 bug 30982 14:06:22 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , Use the REST API for background job list view 14:06:27 bug 27421 14:06:27 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Porting tools/stage-marc-import.pl to BackgroundJob 14:06:28 they are always the same... 14:06:37 (people wanted them, I wrote a patch) 14:06:44 Then, ERM 14:06:53 Joubu: I will test 30718 again soon 14:07:04 If we don't want it to be stuck for months, I need (at least) one or two of you onboard with me 14:07:14 You need to know what the current state is (see kanban) 14:07:27 and understand a bit of the code (I am currently more than 130 commits above master...). 14:07:29 this one? https://tree.taiga.io/project/joubu-koha-erm/kanban 14:07:45 do youmean testing or actual developing? 14:07:46 yes, there is only one 14:07:59 There are missing tests, missing documentation, it's a lot of code and both ERM and Vue are new for most of us 14:08:09 Yippee, build fixed! 14:08:09 Project Koha_Master_D11_My8 build #926: FIXED in 57 min: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/926/ 14:08:09 Congratulations! 14:08:12 cait1: depending on your skills. Feedback from the UI/testing, feedback on the code 14:08:43 if we don't want the project to fail, I need help now. I will be able to answer your questions and it will be easier for you 14:08:44 I can help with Vue if you want 14:08:51 say I have something like "input fields shoudl be longer here and there" - would I put that on the kanban? 14:08:51 Sharpened my skills a little 14:09:01 Especially if we want a first shoot into 22.11 (which would help to get feedback from end users). 14:09:09 cait1: not about the UI 14:09:24 it should be rewritten using Bootstrap 5, but we are not there now 14:09:52 I don't care much about how the UI is (button too big, etc.) considering that minor for now 14:09:56 I'm out for two weeks from Friday, then have some urgent development work to complete the week after... 14:10:01 that kinda rules me out ☹️ 14:10:10 but I was hoping to help progress all of them 14:10:17 ... and with 2 QAers gone, I'll need help too 14:10:36 and I am serious this time. The queue is too full already and we have 2 major QA people on leave soon. 14:10:54 Joubu: so UI testing should be limited to functionality not looks? 14:11:02 Ah yes, summertime ^^ 14:11:10 ...but lots of people on the QA team list, so we shouldn't be so short-handed. 14:11:18 yes, but we are 14:11:20 Project Koha_Master_U20 build #495: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_Master_U20/495/ 14:11:25 summertime is for all queues 14:11:27 mostly, yes. global ergonomic issues could be raised, not "button too big" 14:11:41 it's not there yet 14:12:23 when you say help now, is the intention to get this in before you leave? or what is the goal? 14:12:28 the ERM is an optional module isn't it.. 14:12:53 cait1: to not let it stuck for several months, without move 14:12:55 how tied in to other things is it in terms of possibility to break other area's 14:13:05 it's completely isolated 14:13:15 brill.. I thought it was 14:13:22 experimental module.. 14:13:32 yeah, I thnk we are having the same thought 14:13:36 but no point to push it if I am the only one aware of the code (and not around) 14:14:03 we all need to be aware of the code sooner or later 14:14:05 to maintain it 14:14:09 I'll get up to speed.. but it'll likely be in your last week 14:14:29 * ashimema assumes he knows why your off and that assumes things don't happen early ;P 14:14:30 anyway, I didn't want to monopolise the meeting 14:14:45 it's a good thing to talk about 14:14:49 :) 14:14:57 completely isolated: Does that mean it could be pushed with rough edges and in 3 mo you iterate on it? 14:15:02 Does the stuff to do in a month also include integrating the Cypress tests in our suite and pipeline? 14:15:27 not necessarily 14:15:33 oh, that's a really good question 14:15:34 we have only about 4 months left - so close call, but maybe we could make it work 14:15:45 IIRC it won't work anyway, cypress cannot work without x server 14:16:02 we can have a headless X server, don't we? 14:16:06 we can use xvfb likely 14:16:14 I didn't manage to make it work within ktd 14:16:26 ok 14:17:13 It's a matter of time tinkering (during hackfest I tried to find a container with cypress and browsers ready but couldn't make it work with ktd...) 14:17:14 I don't remember the exact reason. And know I didn't spend much time on it, but I think I found something in the official repo's issue ssaying it couldn't work 14:18:02 ok 14:18:10 Anything else to announce? 14:18:12 that won't prevent integration in the codebase 14:18:20 that's minor anyway, if we are 2 dev on it we can run the tests locally 14:18:31 we should add an info 14:18:34 about the leave 14:18:38 right 14:18:51 tuxayo: I wanted to mention that ashimema asked me if we could test running a vector-im instance for the community 14:19:11 and I will set it soon 14:19:25 https://github.com/vector-im/element-web#running-from-docker 14:19:31 element, client 14:19:36 ah 14:19:40 I was going to ask what that is :) 14:20:17 the idea is to provide more interesting ways for people to interact with the community 14:20:25 testing phase 14:20:27 #infodraftJoubu needs help on bugs 27272, 30718, 30982, 27421 and ERM before going on long starting in less than a month. 14:20:33 like that the note? 14:21:03 sounds good to me 14:21:10 a more modern webchat with access to our IRC channel.... thinking as a replacement for the current oftc hosted webchat 14:21:13 info Joubu needs help on bugs 27272, 30718, 30982, 27421 and ERM before going AFK in less than a month. 14:21:17 tcohen: let me know when it's there, happy to hang out and we use element at work 14:21:22 #info Joubu needs help on bugs 27272, 30718, 30982, 27421 and ERM before going AFK in less than a month. 14:21:32 cait1: sure! 14:21:38 excellent 14:21:39 darn tootin' it is. 14:21:42 thanks tcohen 14:21:55 I'll call it https://element.test.koha-community.org 14:22:25 Once we're happy it's ready we could tweak https://koha-community.org/get-involved/irc/ a bit 14:22:43 perhaps drop 'irc' as a wording and just say 'chat' instead.. 14:22:51 > vector-im instance 14:22:51 Hosting a Matrix server and Element webchat? Shouldn't we try first to find a respectable already hosted public instance? 14:23:10 I know already one from the https://www.chatons.org collective. 14:23:26 tuxayo: that's a good option too. I prefer to try it to get used to it, but yeahg 14:23:29 the irc channel is already bridged to the matrix.org servers and I think serves well enough 14:23:59 this is just to have a simple client and try to encourage people down the matrix/element path rather than joining with irc 14:24:00 I used it a bit https://element.tedomum.net 14:24:00 People managing it and the other services are quite active. 14:24:18 Ah, hosting just the webchat 14:25:03 To have a direct link to come here without creating an account? 14:25:21 that's the aim.. we'll see once testing 14:25:35 lets see.. give it a little trial 14:25:53 shall we move on? 14:26:01 We've been talking about it for ages, it's definitely worth trying 14:26:01 yeah 14:26:07 That's great aim, thank 14:26:11 *thanks 14:26:19 #topic Update from the Release manager (22.05) 14:26:27 tcohen: 🎙️ 14:26:53 Yippee, build fixed! 14:26:53 Project Koha_Master_U22 build #144: FIXED in 1 hr 7 min: https://jenkins.koha-community.org/job/Koha_Master_U22/144/ 14:26:53 Congratulations! 14:27:06 #info master has had some small hiccups, but I've managed to push enhancements and new features 14:27:44 #info tried to detect possible conflicts with bugfixes as much as possible until last week 14:27:58 what do you mean? 14:28:06 master has seen more than 500 commits in the last two months, mostly bugfixes 14:28:25 I mean that I started to push enhancements more often 14:29:04 been trying to mark things for stable and communicated with lukeg about must-backport stuffs for 22.05 14:29:33 tcohen++ 14:29:43 there are a couple failures in Koha_Master that I cannot reproduce locally and cannot commit time to find a fix right now 14:30:03 I'm happy with the QA team so far, they kept me super busy pushing thing 14:30:05 s 14:30:19 revert the culprit ticket? and the dev find it :P 14:30:24 *let the dev 14:30:34 the problem is this has been like that for a while 14:30:49 before the 22.05 release AFAICT 14:31:16 and I cannot ask Joubu for more than he already does 14:31:18 Joubu++ 14:31:34 this is the failing selenium test right? 14:31:37 (he introduced the changes in the testing pipeline) 14:31:40 yes 14:31:40 I've been meaning to take a look 14:31:50 it doesn't fail on normal KTD 14:31:55 but I'm not entirely sure I've got my head around the problem yet 14:32:01 yeah.. that's where I've struggled 14:32:04 it has to do with the way it is installed I think 14:32:28 also, I've been meaning to stop the Ubuntu 18.04 master job 14:32:37 good idea 14:32:43 as we don't really need to support it 14:32:52 and it has a failing test 14:33:13 wait, it can catch early stuff that might fail when backported 14:33:25 ok, that's all from me. About devs, I will focus on some refactoring bugs Joubu already mentioned 14:33:33 ah 14:33:40 Or if the probability that it helps it too low let's drop it anyway 14:33:42 it serves rmaints 14:33:50 ok, no problem from me 14:33:57 Yippee, build fixed! 14:33:57 Project Koha_Master_D11_MDB_Latest build #1022: FIXED in 46 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/1022/ 14:33:57 Congratulations! 14:33:58 I will remove it from the 'Supported' tab 14:34:11 to avoid confusing people seeking for answers in Jenkins 14:34:30 ok, another thing I wanted to mention 14:34:34 If it still fail constantly it not useful as a warning 14:35:27 I think I had something that failed only Ubuntu 18.04 on oldoldstable and I reverted. I had not idea. Maybe it's the same ticket! 14:35:41 no 14:36:25 Ah it was for Ubuntu 16.04 (bug30035) 14:36:27 this: https://jenkins.koha-community.org/job/Koha_Master_U18/lastCompletedBuild/testReport/ 14:36:28 so not related 14:37:03 Ah this >< 14:37:22 I think it is just that the lib version doesn't explode the way our test expects 14:37:36 anyway 14:37:46 that's all from me on this topic 14:37:50 ok 14:37:57 #topic Updates from the Release Maintainers 14:38:01 rmaints? 14:38:01 rmaints are lukeg, liliputech and tuxayo 14:38:11 anyone know when lilputech is back? 14:38:14 nothing interesting from me this month. 14:38:29 I have a few bugs I'm keen to see in the next 21.11.x 14:38:50 ashimema: urgent ones? 14:39:43 the analytics search error one.. the biblioitems acquisisitions on the api one 14:39:50 ah yes 14:39:56 we all need them 14:40:00 mm 14:40:02 indeed 14:40:14 I will contact liliputech 14:40:20 I think he's on leave 14:40:33 yeah, but will ask for permission to push things 14:40:40 I've been chasing them through lucas first 😜 14:40:51 but i'm aware next release is pretty iminent 14:40:56 brill 14:41:13 I can help pushing.. just didn't want to upset his queue if he has a method for working through 14:42:02 Yippee, build fixed! 14:42:02 Project Koha_Master_D10 build #749: FIXED in 1 hr 1 min: https://jenkins.koha-community.org/job/Koha_Master_D10/749/ 14:42:02 Congratulations! 14:42:22 ashimema: ok 14:42:33 There could be a 21.11.x ready with the bugs tested and applied 14:42:42 *21.11.x fork 14:43:05 So when they come back they just have to merge it and release 14:43:58 ashimema: tcohen can you add 21.05.x releases candidate tag on the bug and CC if they need to be in the next 21.05.x also? 14:44:17 yeah, I try to do that 14:44:21 So I can eventually delay the release a bit to be sure I get then from upstream 14:44:33 *on the bugs 14:44:38 I was wondering, do you guys still work from git? like checking all commits for need to backport or do you have a different way? 14:44:40 *and CC me 14:44:57 I noticed some bugs that had been sitting form around May mostly 14:45:00 there's one security bug that we need to add to the release on the last day 14:45:57 cait1: I don't know about the others but I do git log on the upstream branch and process (backport or leave a comment telling I skipped) every ticket 14:46:15 That's good, thx tuxayo 14:46:22 > I noticed some bugs that had been sitting form around May mostly 14:46:22 Maybe there was a handover issue 14:46:47 And some bugs where never examined 14:46:56 it could be, I CCd Rmaint with a comment 14:47:13 I had a script that ran daily to check master vs my todo list.. it would append every bug to my todo list 14:47:18 Lucas was out for a couple weeks. Maybe that's why some things haven't reached the 21.11 and 21.05 branches 14:47:19 then I worked through that 14:47:25 yeah. 14:47:27 timing.. 14:47:41 all good.. I just have some squeeking customers 😜 14:47:48 > I CCd Rmaint with a comment 14:47:48 That's reliable for me but unless the other RMaint confirm it, we don't know if they can process all their bugzilla notifications 14:48:34 The commitment for oldoldstable it way more managable and it's possible to follow everything. 14:48:54 The other have also way more BZ notification since they touch more tickets than me 14:49:23 moving on? 14:49:39 y 14:49:41 #topic Updates from the QA team 14:49:44 qa_team? 14:49:44 qa_team is, like, cait, marcelr, khall, kidclamp, kohaputti, lukeg, aleisha, fridolin, ashimema, tuxayo, nugged, petrova and Joubu 14:49:57 where to start.. 14:50:06 queue is full of stuff, some from May 14:50:18 we notice the summer time and as said earlier, there will be people on leave 14:50:39 so if you signed up for the team, now is the time to step up :) 14:50:52 Project Koha_Master_D11_My8 build #927: SUCCESS in 39 min: https://jenkins.koha-community.org/job/Koha_Master_D11_My8/927/ 14:51:24 I still send weekly emails with the bad and the ugly 14:51:39 cait++ for that 14:51:43 cait1++ 14:51:46 anything to add? 14:52:08 you always forget the good 14:52:11 cait1++ 14:52:14 :D 14:52:18 i will be around after next week to do signoffs so if anyone is in channel and sees me, please suggest which bugs have priority. 14:52:21 yeah, add cool things too 14:52:30 Joubu: that's a good point, I shoudl ty to point the good too 14:52:34 wajasu++ 14:52:56 The good as in the easy and quick ones? 14:52:56 we should celebrate successes more.. Joubu is right 14:53:06 cait1: at least put your favourites :-D 14:53:08 I'm super happy to see the bundles/collections work in 🙂 14:53:09 well I was only refering to the movie :D 14:53:12 wajasu: ususally start with bugs (errors) and if you could look at stuff that has been sitting a while that#s great 14:53:25 I'm super happy to see some of the C4 -> Koha move stuff moving along 14:53:32 hehe.. 14:53:34 yeah.. I know 14:53:34 cait1: ok 14:53:44 tcohen: I am not doing favourites, so usualyl don't want to single out people :) 14:54:01 but I do think it would be a good thing to remind ourselves that although the queues often look high.. there is still loads of progress 14:54:12 it is fair to ask for things you need/want 14:54:14 I often forget that myself and can end up stuck in nagativity 😜 14:54:27 yep, all good points will try :) 14:54:41 but you can always chime in too - that's how it's supposed to work 14:55:00 sorry for this 14:55:11 noise 14:55:16 wajasu, the dashboard is a great place to start.. I can give you some hints and tips on workflows 14:55:18 News from kohagit: Bug 31192: Check for item before calling is_bundle 14:55:19 News from kohagit: Bug 31186: Fix the hidingrules test for result numbering 14:55:20 News from kohagit: Bug 27045: (follow-up) Fix delimiter in header rows 14:55:21 News from kohagit: Bug 30268: Check mandatory fields in addorderiso2709.pl 14:55:22 News from kohagit: Bug 27045: Fix other exports using CSV profiles 14:55:23 News from kohagit: Bug 27045: Fix items lost report export if delimiter is tab 14:55:31 we like this kind of noise! 14:55:31 lol 14:55:35 tuxayo: move on? 14:55:43 I tend to pick a small one or two bugs to get me started then follow with a harder one to keep the queues moving. 14:56:29 #topic Status of roadmap projects 14:56:39 i'm getting used to ktd. with an easy bug. then will move on. 14:57:06 Anything from anyone on a project? 14:57:18 #link https://annuel.framapad.org/p/koha_22.11_roadmap 14:57:37 Deferred pointing to test01 for wiki testing while standing up test00 running on Debian 10. 14:58:09 #info ashimema and tcohen have been talking about spending some days on C4::Reserves 14:58:12 Project Koha_Master_D11_ES7 build #29: SUCCESS in 8 min 24 sec: https://jenkins.koha-community.org/job/Koha_Master_D11_ES7/29/ 14:58:21 +1 14:58:39 thd: do you still need testing, waht makes sense right now? 14:58:50 I saw tuxayo had left a commen ton the wiki bug 14:59:01 #info many things in the Roadmap have patches and need eyes/testing 14:59:17 Testing is still needed I just did not want to confuse the whole mailing list by changing URIs. 14:59:28 I'll be taking stock and getting back to the roadmap things once I'm back from vacation 😜 14:59:40 been a crazy few weeks... but then,, when is it not 15:00:07 thd: can you give the current one? 15:00:09 You would not be confused. The same bugs will be present but I might only fix them on Debian 10. 15:00:11 I'll try to make time end of week 15:01:00 I've been working on follow-ups to Bug 30952. I'm doing some cleanup to reduce the number of template changes. 15:01:00 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 enhancement, P5 - low, ---, solene.desvaux, Failed QA , New interface for staff client 15:01:29 oleonard++ 15:01:34 great 15:01:36 thd: are you planning to go live on D10? 15:01:37 oleonard++ 15:01:39 https://koha-mw-my-test00-upgr.agogme.com/ is not up yet. I just now fixed a manual package override needed for running apt-listbugs for a kfreebsd issue nothing to do. 15:01:57 We should probably go live on Debian 11. 15:02:20 thd: just point me where i need to test - I'll try to spend some time Friday 15:02:34 Debian 10 has one slightly different package names. 15:02:39 thd: what's the timeframe? 15:02:41 thd: do you have an automated process for migrating the data? 15:03:05 The process is entirely automated as much as possible. 15:03:31 https://koha-mw-my-test01-upgr.agogme.com on Debian 9 is still current at this moment. 15:03:53 when will it be ready? What's missing? What's the timeframe? Do you need help? If so, what? 15:03:58 https://koha-mw-my-test00-upgr.agogme.com should become current anytime now. 15:03:58 I am tired of waiting for this wiki 15:04:06 I have helped 2 years ago, it was ready... 15:04:09 ++ 15:04:23 thd: would you be ok with us launching a mediawiki instance in wiki.test.koha-community.org in which we use the automated process you come up with? 15:04:25 cannot we just go live "now"? 15:04:36 I am also in favor of a quick move 15:04:36 okay, cait1. 15:04:44 I think we coudl still fix some stuff later 15:05:12 If the full size images don't work for now that's okay 15:05:15 I agree 15:05:20 There are a few installation bugs for changed package names which I may have now fixed. 15:05:46 thd: but what if we had the vanilla install sorted 15:06:04 https://hub.docker.com/_/mediawiki 15:06:07 there is not a ton of changes on the current wiki, having a bit of a 'freeze' would not hurt a lot if it helps the move 15:06:23 Full sized images is not a problem with apache. 15:06:34 good 15:06:47 So any blockers? 15:06:56 It only takes about an hour to run. 15:07:40 Blockers are just finishing standing things up on Debian 10 which probably also works on Debian 11. 15:08:24 when can we go live? 15:08:30 we need a deadline 15:08:38 thd, I will send you an email about your automated migration process. So we can test it too 15:08:59 I really think we could simplify the process by using the OFFICIAL Docker images 15:09:01 as-is 15:09:16 I see there's a LocalSettings.php file 15:09:26 We should be able to go live by the end of Aug. 15:09:34 great! 15:09:42 excellent 15:09:42 darn tootin' it is. 15:09:44 do we need a server? 15:09:56 or will we use the current one? 15:09:57 There are four LocalSettings.php files. 15:10:31 The current one runs on an old version of Debian which is needed to make it work. 15:10:38 ok, can you put some of those specifics on an email to Joubu, ashimema and I? 15:10:45 I won't be able to help 15:10:49 no need to include me 15:10:53 ok 15:10:58 include Joubu anyway 15:10:59 :-P 15:11:04 lol 15:11:20 I would like to know which MediaWiki version is too 15:11:41 if the process is almost done, maybe we shoudl not make big changes now 15:11:43 we need a sustainable way to handle the wiki deployment 15:11:44 We will need a new Debian 10 or 11 instance for live. 15:12:04 and I think the great job you've done with the migration process 15:12:18 could pair well with one of this modern deployment methods available 15:12:24 so we can team up 15:12:54 Changes are merely to have things running on Debian 10 or 11 and reproducible. 15:13:10 > I would like to know which MediaWiki version is too 15:13:12 https://wiki.koha-community.org/wiki/Special:Version 15:13:16 https://koha-mw-my-test01-upgr.agogme.com/wiki/Special:Version 15:13:23 thanks Tuxayo 15:13:50 MediaWiki 3.5 LTS 15:14:11 *1.35 ? 15:14:31 1.37 15:14:41 1.35.7 15:14:41 The scripts I have written can be adapted to any future update for testing. 15:14:45 ok, it is the LTS 15:15:14