14:02:34 #startmeeting Development IRC meeting 22 June 2022 14:02:34 Meeting started Wed Jun 22 14:02:34 2022 UTC. The chair is tuxayo. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:02:34 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:02:34 The meeting name has been set to 'development_irc_meeting_22_june_2022' 14:02:54 #link https://wiki.koha-community.org/wiki/Development_IRC_meeting_22_June_2022 Today's agenda 14:03:07 #topic Introductions 14:03:08 o/ 14:03:09 #info Martin Renvoize, PTFS Europe, UK 14:03:14 #info Owen Leonard, Athens County Public Libraries, Ohio, USA 14:03:20 #info Arthur Suzuki, BibLibre, France 14:03:31 #info Tomás Cohen Arazi, Theke Solutions, Argentina 14:03:40 #info Andrii Nugged, National Library of Finland, Helsinki, FI 14:03:54 #info Thomas Dukleth, Agogme, New York City 14:04:05 #info Victor Grousset, Tuxayo VZW, France 14:04:32 #info Nick Clemens, ByWater Solutions 14:06:15 shall we move on? 14:06:55 unlikely to get davidnind right.. he put something on the agenda but it's poor timing for him 14:07:03 yes 14:07:30 #topic Announcements 14:07:51 Anything to announce that doesn't fit better the other topics? 14:07:53 Project Koha_Master_U22 build #101: SUCCESS in 1 hr 5 min: https://jenkins.koha-community.org/job/Koha_Master_U22/101/ 14:08:28 #info Katrin Fischer, BSZ, Germany 14:08:44 #topic Update from the Release Manager (22.05) 14:08:54 tcohen: 🎙️ 14:09:47 hi 14:10:21 We have passed string freeze for the stable releases, and several bugfixes have been pushed for 22.05 14:10:34 I will start integrating enhancements and new features soon 14:10:46 will try to not touch sensible areas that have outstanding bugs 14:10:52 on the first weeks 14:11:47 long live the new rm 14:11:50 Devs should looks at the roadmap and add the things they want to work on 14:12:13 I'm open to chat/video call with people willing to engage team work 14:12:15 #info Lucas Gass, ByWater Solutions 14:12:17 if required 14:12:31 tcohen++ 14:12:51 tcohen++ 14:13:15 tcohen++ 14:14:21 Anything else tcohen ? 14:15:19 I would like to mention the new 'ktd' command in KTD 14:15:21 wow 14:15:25 will send an email about it 14:15:42 would like testers to try it before we tweak the docs 14:16:12 tcohen+=3; from all our FI team (I can represent, yes) 14:16:25 https://gitlab.com/koha-community/koha-testing-docker/-/issues/300 14:16:36 it is already merged and can be used 14:17:06 tcohen++ 14:17:48 what does ktd do? 14:17:48 #info Testers needed for new koha-testing-docker management script. See https://gitlab.com/koha-community/koha-testing-docker/-/issues/300 14:18:32 cait1: it replaces the aliases 14:18:42 or aliases could be rewritten in terms of it 14:18:56 the issue describes a usability problem we have for daily stuffs 14:20:07 When using various images (for es versions for example) one had to manually pick the right docker-compose.yml files to update the images. 14:20:13 Project Koha_Master_U20 build #446: UNSTABLE in 36 min: https://jenkins.koha-community.org/job/Koha_Master_U20/446/ 14:20:34 just please write easy to read docs :) 14:20:39 I'll read those then 14:21:00 the README will get hughly simplified 14:21:05 ++ 14:21:08 +1 14:21:13 don't let me hold up things 14:21:15 move on? 14:21:38 If there is something else, we can come back later 14:21:39 #topic Updates from the Release Maintainers 14:21:43 rmaints? 14:21:43 rmaints are lukeg, liliputech and tuxayo 14:22:51 as of the release maintenance of 21.11, I'm almost ready to release the 21.11.07, just missing access to community wordpress and download site to push to. 14:22:54 1sts commits pushed so I have the rights on the branch and will be able to release on friday 14:25:00 i didn't pick bug30733 yet because it changes a lot the templates and i didn't feel very secure to add it this close to the release (lots of templates changes), but I'll work on it for 21.11.08 (be nice with translators). 14:25:08 I need to investigate some some failures on Ubuntu 16.04 that I inherited otherwise, that's all 14:25:34 liliputech: you need to contact gmcharlt rangi or Liz Rea according to https://wiki.koha-community.org/wiki/Website_Administration#download.koha-community.org 14:25:43 for download 14:25:48 bug 30733 14:25:48 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 enhancement, P5 - low, ---, victor, Pushed to stable , Simplify translatable strings 14:25:54 sent an email to liz just minutes ago :) 14:25:56 i think I wouldn't push that one 14:25:56 is it actualyl worthwhile backporting 30733 any further.. ? 14:26:12 ha.. great minds 14:26:14 it creates a lot of work for translators 14:26:21 ashimema totally not 14:26:24 and the later the version the more unlikley people keep up 14:26:25 It's a mess ^^ 14:26:30 if it's not i can manage not to work on it ;) 14:26:32 I don't think we should.. it would do the oposite of what it tries to do.. get translators to re-translate a lot 14:26:37 30733 was only for 22.05 14:26:48 yep, I think it's good there 14:26:49 ok, then i will resolve-fix that one :) thx! 14:26:56 it's great for the case where they've not already translated much.. but that your points in the cycle it should be left out. 14:26:57 coolios 14:26:58 but it took me a few hours to go through 14:27:09 For earlier versions it would be bad for translators to have so much work so late in the life cycle 14:27:18 cait++ 14:27:23 * liliputech applause 14:27:25 brill 14:27:33 so we all agree, less work for liliputech :) 14:27:39 \o/ 14:28:35 liliputech: for other patches, if it meets the backport criteria in the RMaint doc but it conflicts, just let a message that if someone needs it they should provide a backport. 14:29:19 liliputech: I think you said you had issues with bug 30717 so just write that in the ticket 14:29:19 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717 major, P5 - low, ---, jonathan.druart+koha, Pushed to master , Dates displayed in ISO format when editing items 14:29:42 moving on? 14:29:47 ++ 14:29:47 +1 14:29:49 tuxayo: when it's small conflicts, i tend to fix them, but yes, sometime i just cannot guess what is the "proper" way to fix, then I would ask for help :) 14:29:50 #topic Updates from the QA Team 14:30:02 qa_team? 14:30:02 i heard qa_team was cait, marcelr, khall, kidclamp, kohaputti, lukeg, aleisha, fridolin, ashimema, tuxayo, nugged, petrova and Joubu 14:30:36 * ashimema is a little behind this month.. lots of meetings.. 14:30:51 > small conflicts, i tend to fix them, but yes, sometime i just cannot guess what is the "proper" way to fix, then I would ask for help :) 14:30:51 That's the way, ask for help and then forget about it, just don't miss your bugzilla notification in case someone steps up 14:31:04 * 65 submissions in the queue, 24 of them bugs 14:31:21 yep, PLEASE QA! 14:31:35 Project Koha_Master_D11_MDB_Latest build #967: SUCCESS in 43 min: https://jenkins.koha-community.org/job/Koha_Master_D11_MDB_Latest/967/ 14:31:44 be nice to get that first number back down under 50.. and we should strive to keep the bugs number lower 14:31:56 I highlighted bad bugs in the Monday email, there is still quite a few 14:31:58 I think I'm locked out of a number of the bugs.. 14:32:06 new ones, not the old ones.... 14:32:45 also some bad bugs in Needs Signoff to grab for everyone and help us processing them 14:33:32 bug 29325 in particular would be good to get some eyes on. 14:33:32 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325 critical, P5 - low, ---, nick, Signed Off , commit_file.pl error 'Already in a transaction' 14:33:41 yes, please! 14:34:28 and please also check the security project - they don't show up on dashboards - they will be visible in the saved lists and have permission/are logged in 14:34:37 also bug 30889 (or help moving the alternative Joubu suggested forward.. that one's on my list) 14:34:37 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889 major, P5 - low, ---, martin.renvoize, Signed Off , Background jobs lead to wrong/missing info in logs 14:34:37 all QA team members have access to anything security by default 14:35:24 Not QA specifically but signoffs: I'm launching SO sessions with french speaking librarians (and will do in english if that works well) Does anyone have contacts with Koha users in Africa? 14:35:25 Because most french speakers are actually there and it would be a good way to strengthen the librarian community. 14:35:54 Great initiative tuxayo 14:37:48 tuxayo++ 14:37:52 maybe you could ask rangi 14:38:00 #info anyone who have contacts of Koha users in french speaking Africa contact victor AT tuxayo DoT net so we can make patch testing session with librarians 14:38:17 cait1: good idea 14:38:26 #topic Status of roadmap projects 14:38:39 #info https://annuel.framapad.org/p/koha_22.11_roadmap 14:39:41 I have not yet added wiki db migration and update to the new roadmap. 14:39:50 please do thd 14:40:03 I updated https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 14:40:03 04Bug 23073: normal, P2, ---, td-koha-bugs, NEW , wiki.koha-community.org needs updating to a later version 14:40:11 do you have help from other community members? 14:40:24 I know some volunteered to help in past meetings 14:41:06 lots of us waiting and wanting to help 14:41:09 Yes, mtj is working on automated validation that the data migrated without errors was actually migrated without errors and not dropped somewhere. 14:41:29 I'll try to have a look at the testing site tomorrow 14:41:29 do we have a timeframe? 14:41:45 but maybe others could help too? we had discussed this earlier on IRC this morning 14:42:02 git://test01.agogme.com/koha-migrate-mwiki-db-and-upgrade-test.git is now up. 14:42:51 thd++ mtj++ 14:43:10 That may be a message of the sort one sees for several days after reinstallation while some processes run gradually. 14:43:19 oops 14:43:47 Yippee, build fixed! 14:43:48 Project Koha_Master build #2070: FIXED in 1 hr 9 min: https://jenkins.koha-community.org/job/Koha_Master/2070/ 14:43:48 Congratulations! 14:44:20 Reinstalled test instance of the Koha Wiki using Postgres at https://koha-mw-pg-test01.agogme.com/ . 14:44:21 Koha test wiki migrated to MySQL at https://koha-mw-my-test01.agogme.com/ . 14:44:21 Koha MySQL test wiki upgraded to MediaWiki 1.35 LTS at https://koha-mw-my-test01-upgr.agogme.com/ . 14:45:08 Be mindful that various work will take those down and regenerate or slow them down at times. 14:45:35 thd: have you pondered a dockerized setup? 14:45:41 Those test instances have been mostly up for over a year. 14:45:51 we have a big server that is only serving koha-api-docs right now 14:45:57 and I can arrange you access to it 14:46:49 I have never learned enough of docker to actually use it for anything. 14:47:26 ok, but if we managed to set a running MediaWiki instance there 14:47:41 I think we shoudl not change the process too much now 14:47:41 it would be a matter of copying the files and loading the DB, right? 14:47:46 let's finish it and then move to docker? 14:47:59 +1 14:48:19 did you bring across user acounts into your test? 14:48:20 agreed 14:48:24 It is somewhat more than copying the files and loading the DB. 14:48:25 sorry for the noise 14:48:27 ashimema: i coudl log in 14:48:40 ok 14:48:41 I brought over everything. 14:48:57 so let's say mtj declares the migration is good 14:49:07 and we don't find anything too troublesome 14:49:16 thd: looks great, what is missing? 14:49:25 There is no mail server running on my VPS so you cannot change your password but everything works. 14:49:29 do we define a 'cut off' date then and can we set the wiki to read only whiel we move? 14:49:38 Automated testing would be nice. 14:50:37 mtj said that he was working on automated testing since we discussed what was needed last meeting. 14:50:56 Testing what? 14:50:56 i guess Testing is important :) 14:51:54 yes, wahanui 14:51:54 yes is something different :) 14:51:58 Testing that the migration from Postgres to MySQL did not drop anything consequential other than cached values or indexes. 14:52:00 XD 14:52:18 Nothing appears to be different. 14:52:29 > Testing that the migration from Postgres to MySQL did not drop anything consequential other than cached values or indexes. 14:52:29 Ah I see so to avoid subtle issues 14:53:08 There is an unpleasant warning when reloading the database from Postgres. 14:53:57 Yet my investigation finds no actual problem. 14:54:39 Considering all looks great don't hesitate to drop the automated check if it turns out to be too hard. IHMO 14:54:52 +1 14:54:58 done with some minor bugs we didn't spot and can fix later is better than not done at all 14:55:04 I am looking forward to clean up categories some 14:55:11 it's been ongoing since early 2019 from memory 14:55:35 Yes, the pandemic has wrecked my schedule. 14:55:36 the new(?) editor for categories seems to work well (tested earlier) 14:56:12 moving on? 14:56:20 was about to say that 14:56:26 I have a small fraction of the time I had before the pandemic. 14:56:39 Thanks for the great news about the wiki thd++ 14:56:43 #topic Actions from the last meeting 14:56:51 « tuxayo add requesting access for ssh access for download.koha-community.org in Initial_setup of rmaint doc » 14:56:51 done 14:56:55 « davidnind to create bug to summarise discussions and next steps for LTS version of Koha » 14:56:57 lol.. we missed the whole of the existing roadmap stuff 14:57:00 no worries 14:57:28 existing roadmap stuff? 14:57:35 Ok I'll back to that in the general part 14:57:47 david created bug 31008 14:57:47 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31008 new feature, P5 - low, ---, koha-bugs, NEW , Long Term Support (LTS) version of Koha 14:57:47 no worries.. it can wait for next time 14:58:11 I haven't read the bug yet 14:58:20 but the idea was to label 21.11 LTS 14:58:22 Project Koha_Master_D10 build #693: SUCCESS in 38 min: https://jenkins.koha-community.org/job/Koha_Master_D10/693/ 14:58:31 with a promise to support it for... 2.5 years I think? 14:58:49 Paul raised a question on the ML but not sure if ti's an issue 14:59:06 I think someone running LTS Koha might also be more likely to go LTS on the OS? 14:59:47 I don't think too many issues shoudl be expected there in terms of dependency issues? 15:00:14 Looks okay when I see for oldoldstable since 2 years 15:00:56 I never had issues to switch a big depence 15:00:58 bye 15:01:03 *dependence 15:01:16 yes, I think we should just go with it 15:01:34 the "test" wth 19.11 didn't bring up anything like it 15:01:42 right! 15:01:42 yowsers.. is it not like 3am where you are davidnind 15:01:56 yowsers? 15:02:11 5 am i think 15:02:14 Apologies for only doing the bug/email yesterday... 15:02:18 it will heavily rely on volunteers from an already small pool supporting it 15:02:26 davidnind++ 15:02:28 thx for doing it davidnind++ 15:02:30 3am 😄 15:02:33 how do we pick which bersions become LTS 15:02:33 thanks for the summary ^^ 15:02:56 * ashimema goes quiet as he's not read the details for ages and can't remember 15:03:01 ah... 10 the other way 15:03:25 ashimema: what we discussed last time was using oldstable 15:03:40 we can't always use 'oldstable' 15:03:44 2 years... jump to current oldstable 15:03:53 no not always 15:03:55 ok 15:03:59 there will be gaps of course 15:04:14 so once every two years we drop one LTS and replace it with whatever oldstable currently is 15:04:16 I see 15:04:25 taht was the idea discussed 15:04:31 we'd certainly need to publish that clearly.. 15:04:41 we are in the process :) 15:04:59 and make sure the RM overseeing that particular release when it first comes out is very much aware 15:05:23 hm why? 15:05:29 I think it needs up front commitment at development time.. for it to be a really good LTS it likely needs a 6 month polish before release 15:05:33 we get about 6 maint releases in 15:05:35 By the time it because oldstable it should be polished 15:05:41 because LTS is always meant to be much more stable and reliable.. from day one 15:05:45 that was the idea yes 15:06:02 that's why we wanted to pick .6 15:06:02 in general an LTS release is LTS announced as LTS at release time 15:06:14 > much more stable and reliable.. from day one 15:06:14 If it not advertised as LTS on day one then we don't need that 15:06:32 I don't think that's doable to be honest 15:06:44 it will be the .6 release when it' announced 15:07:01 or the .7 ... might be off by a month not sure 15:07:02 OK.. well.. if there are people wanting to take it on.. fine with me. 15:07:35 I would say we're not doing LTS.. we're doing a random Extended support 15:07:42 I just think with manpower we have a super careful release is probably not on the map atm... people want new things etc, I understand the argument, but trying to find some middle ground 15:07:45 but hey.. that's just semantics 15:07:54 we coudl also call it extended support 15:07:57 but it won't be random 15:08:06 goal is to put this into a schedule 15:08:48 It's not convenient for people to have to upgrade from the LTS-1 to the new LTS a few months after their install but having a .00 labelled LTS would give worse results. 15:09:45 if we make it predictable, that will give people the option 15:09:49 wait, it's not and issue 15:10:07 * tcohen needs to leave to feed the kids 15:10:24 Because when the LTS is oldstable and oldoldstable, it's maintained by the usual RMaint 15:10:38 So the real LTS-1 is still maintained 15:11:06 So there is not the issue to have to do a major upgrade a few months after installing an LTS 15:11:44 we might need to do a graphic 15:11:46 my head hurts 15:11:55 but I think extended support is a realyl great idea 15:12:21 we do have some difficulty keeping up with the current schedule 15:12:22 extended support is a good term also. 15:12:30 yes, happy witht hat 15:12:38 > keeping up with the current schedule 15:12:38 What do you mean? 15:12:56 [off] that we tend to get stuck on EOL versions 15:13:27 Great, that confirms the need for an extended support/LTS version 15:13:41 so LTS gets 18month support 15:13:44 #info consider naming extended support instead of LTS 15:13:51 as it only become LTS after 6 months of release 15:13:53 the idea was 2 years to 2.5 actually 15:13:53 Project Koha_Master_D12 build #174: STILL UNSTABLE in 1 hr 5 min: https://jenkins.koha-community.org/job/Koha_Master_D12/174/ 15:13:54 right? 15:13:59 > 18month support 15:13:59 That's the normal thing. 15:14:23 I will try to draw it 15:14:26 so 2 years would mean maintaining it for 2.5 years right 15:14:36 for the 21.11 example 15:14:42 because it's only LTS after the first 6 months of maint 15:14:57 yeah you coudl phrase it like that 15:14:59 i think 15:15:11 > it's only LTS after the first 6 months of maint 15:15:11 It's actually LTS only after 18 months of RMaint, that when the LTS RMaint take over 15:15:12 so by the end of LTS support someone would be running a feature stable software written 2.5 years before 15:15:20 ok.. I can sorta understand theat.. 15:15:27 Yippee, build fixed! 15:15:27 Project Koha_Master_U20 build #447: FIXED in 43 min: https://jenkins.koha-community.org/job/Koha_Master_U20/447/ 15:15:27 Congratulations! 15:15:33 and they need to upgrade every 2 years 15:15:46 nah 15:15:55 it's LTS the moment it's deemed to be the LTS we're going to support 15:16:11 #action cait try to draw how extended support/LTS would work 15:16:14 maybe calling it extended support we could call it that from day one? 15:16:18 heh 15:16:20 thx 15:16:22 if it's only LTS when they maint takes it on then it's actually only 6 months or whatever 15:16:44 let's postpone and think it over? 15:16:56 ashimema: the LTS RMaint add more than 6 months 15:16:58 i think another 2 weeks is not going to kill it 15:17:07 * ashimema would still have prefered to see effort go into stabalising code earlier, more CI and creating a rolling release 15:17:49 lets move on 15:17:53 > call it that from day one? 15:17:53 Wouldn't it be a less good experience if people needing an extended support install a .00 ? 15:18:46 > ashimema would still have prefered to see effort go into stabalising code earlier, more CI and creating a rolling release 15:18:46 You can throw brainpower here: https://wiki.koha-community.org/wiki/LTS_workflow_proposal 15:18:46 Warning, it's draining ^^ 15:19:03 « davidnind request feedback for the above on the mailing list with next dev meeting (two weeks from now) as a deadline » 15:19:04 done 15:19:10 on koha-devel 15:19:21 « liliputech discuss koha CI (docker image built + manuall build) hosting on gitlab instance provided by BibLibre's partner AFI. » 15:20:55 #action liliputech discuss koha CI (docker image built + manuall build) hosting on gitlab instance provided by BibLibre's partner AFI. 15:21:04 #topic General development discussion (trends, ideas, ...) 15:21:06 tuxayo: about this, people at AFI said it might be OK to host a mirror on our gitlab instance, I just got a warning about ressource use (do we have any estimation for CPU/memory use?) 15:21:40 > host a mirror 15:21:40 not needed IIUC 15:21:55 It's about CI runners 15:22:20 liliputech++ thanks for asking 15:22:42 i need more info about ressource usage to move on, and some clues about how to build a runner. 15:23:22 would it need people external to biblibre to have an account on our gitlab? 15:23:32 (like push access?) 15:23:37 I don't believe so 15:23:53 My guess is that you can note to ask tcohen and mtj about ressources. 15:23:59 I'm confused.. not sure who asked for what 15:24:30 My understanding is we're struggling for CI resource for some of the bigger builds basically.. so it's s docker runner 15:24:39 the code is hosted fine where it is 15:24:49 Yes, code is fine 15:25:29 * ashimema needs to disappear soon.. kids duties 15:25:40 ok. I will ask tcohen. we've build a runner for other use (other than koha) not so long ago, we could do it once more, but I guess there are tokens or other stuff we need. 15:25:57 it's a 5min job 15:26:05 One solution would be to host a portainer node on AFI/BibLibre infrastructure and then we can put any docker container there. tcohen manages the portainer thing. 15:26:37 moving on? 15:27:12 «New status for development work flow and dashboard - 'Needs documenting' (see bug 30998) » 15:27:12 04Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30998 enhancement, P1 - high, ---, david, ASSIGNED , [DOCS] Managing documentation tasks - simplify processes and integrate more with the development process 15:28:14 Basically.. have a look at the proposal on the bug.. we're already trialling some of it.. 15:29:06 sorry, I have to leave, have a nice 'day' everyone :) 15:29:06 there's a new status on bugzilla, 'Needs documenting' akin to 'Needs signoff' that sits after 'Pushed to X' and before 'Resolved'.. that status is being used to populate a todo list and status list on the dashboard so far 15:29:32 Great, I see RMaints are mentioned so homework is to read the ticket 15:29:34 rmaints? 15:29:34 rmaints are lukeg, liliputech and tuxayo 15:29:36 ↑ 15:30:06 (Great was about things being trialled) 15:30:33 it's to give docs people a clear list of bugs to work through... and to help spread the load keeping on top of it... so rather than the docs manager having to maintain out of band lists and look at every bug.. docs team can work through the list and get 'points' be submitting docs or making the decision that a particular bug doesn't need any docs changes and so can just be marked resolved 15:31:15 for Rmains the main change is 'use "Needs documenting" where you would have used 'Resolved Fixed' in the past. 15:31:30 ok 15:31:40 lucasg is already on board with it and the majority of these will hit him first 15:32:38 most of the thing I'll put on my branch are already documented isn't it? 15:32:47 what I'm still not sure about is the docs team side bits.. whether we should track submission + pushed states somehow in bz side.. to build more lists on the dashboard 15:32:48 (mine being 21.11) 15:32:57 well.. they 'should be' liliputech 😜 15:33:09 hum ^^ 15:33:47 keep doing what your doing.. if a bug hits you that you push.. use 'Pushed to X'.. if a bug hits you that you decide not to backport use 'Needs documenting'.. then the docs team will come along and make the final step to 'Resolved fixed'.. 15:33:52 liliputech: IIUC So it's when not backporting due to issues or not important enough, we use "Needs documenting" instead of "Resolved Fixed" 15:34:07 I also work on another software, documentation is part of the workflow for proposing an enhancement. that means, no dev can reach code-base without documentation. 15:34:13 it puts it on them to check if there's a new syspref or change of behavour that aught to be documented 😜 15:34:24 yeah.. I tried that 15:34:33 > no dev can reach code-base without documentation 15:34:33 Not the case in Koha 15:34:36 didn't get much support 15:35:03 devs don't like documenting and we already have a really long lead time for code to get in with our SO + QA queues.. 15:35:19 adding in 'Failed QA, no docs' was seen to put people off more.. 15:35:24 which is a shame 15:35:33 but, whose at the best place for documenting than the dev who provides the code? 15:35:40 Indeed 15:35:50 true 15:35:53 s/whose/who is/ 15:35:56 . 15:36:10 feel free to propose that alternative 15:36:17 in the bz? 15:36:37 I have a hard enough time persuading people to upstream code 😜 15:36:40 yeah.. it's as good a place 15:38:58 this would at least make it a more visible part of the process - pushed to x, then needs documenting 15:39:20 maybe we could have a status "Failed QA, missing documentation" which the documentation team could also unblock for the oldest ones. 15:39:20 I can add that to the ticket also. 15:39:42 our process also means that often the feature changes allot between initial submission and pqa.. when that's the case you really need to document at the end else it's just another thing to constantly be adapting throughout the process.. but if you submit it at the end and the code isn't pushed once it's PQA it adds another burden to the dev to also keep rebasing the code and likely another QA run when the rebases aren't trivial.. 15:40:01 we've often seen code pushed that's pretty functionally broken because of a lag between PQA and actual Push 15:40:19 > and the code isn't pushed once it's PQA it adds another burden to the dev to also keep rebasing the code and likely another QA run when the rebases aren't trivial.. 15:40:19 right >_< 15:40:33 added my 2 cents on the bz 15:40:45 I did propose a requirement for docs submissions alongside dev submissions back when I was RM 😜 15:40:55 I don't think we would want to be a blocker for changes getting into Koha 15:40:59 liliputech++ 15:41:01 so I do like the idea liliputech.. just explaining why my proposal failed when it did back then 15:41:24 wow.. me being RM feels like a long time ago now 15:41:31 moving on? 15:41:38 yup 15:41:52 ashimema: you had something I skipped earlier 15:41:57 I can note for next meeting 15:41:58 ashimema++ 15:42:03